device/usb/usb_device_filter_unittest.cc - Issue 2266153002: Modify UsbDeviceFilter::MatchesAny to return true for empty filters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/usb/usb_device_filter_unittest.cc

Issue 2266153002: Modify UsbDeviceFilter::MatchesAny to return true for empty filters (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed code for unit test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: device/usb/usb_device_filter_unittest.cc

diff --git a/device/usb/usb_device_filter_unittest.cc b/device/usb/usb_device_filter_unittest.cc

index df1a223dec76030b3d10b273dfc5605811cda538..a12d54758cd8599965e6699e78de8fc7b8a58bef 100644

--- a/device/usb/usb_device_filter_unittest.cc

+++ b/device/usb/usb_device_filter_unittest.cc

@@ -103,9 +103,9 @@ TEST_F(UsbFilterTest, MatchInterfaceProtocolNegative) {

ASSERT_FALSE(filter.Matches(android_phone_));

}

-TEST_F(UsbFilterTest, MatchAnyEmptyListNegative) {

+TEST_F(UsbFilterTest, MatchAnyEmptyList) {

std::vector<UsbDeviceFilter> filters;

- ASSERT_FALSE(UsbDeviceFilter::MatchesAny(android_phone_, filters));

+ ASSERT_TRUE(UsbDeviceFilter::MatchesAny(android_phone_, filters));

}

TEST_F(UsbFilterTest, MatchesAnyVendorId) {

« no previous file with comments | « device/usb/usb_device_filter.cc ('k') | extensions/browser/api/device_permissions_prompt.cc » ('j') | no next file with comments »