Convert Settings::rootLayerScrolls to RuntimeEnabledFeatures

Convert Settings::rootLayerScrolls to RuntimeEnabledFeatures

Settings are sometimes difficult to get access to, depend on the context.
Also we don't find any use cases to applying different rootLayerScrolls value
to individual frames. Migrating to RuntimeEnabledFeatures to simplify code.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/1d1f13a9f7961b2b891b858c769dc7f2b787e8f8
Cr-Commit-Position: refs/heads/master@{#414804}

[trchen, 2016-08-20 04:17:49]

Description was changed from

==========
Convert Settings::rootLayerScrolls to RuntimeEnabledFeatures
==========

to

==========
Convert Settings::rootLayerScrolls to RuntimeEnabledFeatures
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[trchen, 2016-08-20 04:17:55]

The CQ bit was checked by trchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-20 04:18:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[trchen, 2016-08-20 04:18:50]

trchen@chromium.org changed reviewers:
+ skobes@chromium.org

[trchen, 2016-08-20 04:18:51]

Pretty mechanical. We can wait after other conflicting changes landed.

[commit-bot: I haz the power, 2016-08-20 05:18:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-20 05:18:11]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[skobes, 2016-08-21 14:21:21]

lgtm

https://codereview.chromium.org/2258523006/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/FrameViewTest.cpp (right):

https://codereview.chromium.org/2258523006/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/FrameViewTest.cpp:72:
RuntimeEnabledFeatures::setRootLayerScrollingEnabled(GetParam());
Why is this in TearDown?

[pdr., 2016-08-22 18:02:33]

Nice! This'll make it much easier to make SPV2 require RLS.

[trchen, 2016-08-24 01:01:19]

The CQ bit was checked by trchen@chromium.org to run a CQ dry run

[trchen, 2016-08-24 01:01:55]

https://codereview.chromium.org/2258523006/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/FrameViewTest.cpp (right):

https://codereview.chromium.org/2258523006/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/FrameViewTest.cpp:72:
RuntimeEnabledFeatures::setRootLayerScrollingEnabled(GetParam());
On 2016/08/21 14:21:21, skobes wrote:
> Why is this in TearDown?

Whoops, probably a mis-paste. Deleted.

[commit-bot: I haz the power, 2016-08-24 01:02:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 04:54:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 04:54:04]

Dry run: This issue passed the CQ dry run.

[trchen, 2016-08-24 08:21:55]

The CQ bit was checked by trchen@chromium.org

[trchen, 2016-08-24 08:21:55]

The patchset sent to the CQ was uploaded after l-g-t-m from skobes@chromium.org
Link to the patchset: https://codereview.chromium.org/2258523006/#ps20001
(title: "rebase & fix mistake")

[commit-bot: I haz the power, 2016-08-24 08:22:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 08:30:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 08:30:14]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[trchen, 2016-08-24 21:18:53]

trchen@chromium.org changed reviewers:
+ esprehn@chromium.org, pdr@google.com

[trchen, 2016-08-24 21:18:54]

Whoops, missing owners.

+pdr:
third_party/WebKit/Source/platform/
third_party/WebKit/Source/web/
third_party/WebKit/public/web/

+esprehn:
content/child/
content/renderer/

[pdr., 2016-08-24 22:10:02]

On 2016/08/24 at 21:18:54, trchen wrote:
> Whoops, missing owners.
> 
> +pdr:
> third_party/WebKit/Source/platform/
> third_party/WebKit/Source/web/
> third_party/WebKit/public/web/
> 
> +esprehn:
> content/child/
> content/renderer/

LGTM

[esprehn, 2016-08-25 23:55:27]

Description was changed from

==========
Convert Settings::rootLayerScrolls to RuntimeEnabledFeatures
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Convert Settings::rootLayerScrolls to RuntimeEnabledFeatures

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[esprehn, 2016-08-25 23:55:27]

esprehn@chromium.org changed reviewers:
+ pdr@chromium.org

[esprehn, 2016-08-25 23:59:24]

What's the reason for this? It has us doing copy-pasta all over for the
settings?

https://codereview.chromium.org/2258523006/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/PaintControllerPaintTest.h (left):

https://codereview.chromium.org/2258523006/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PaintControllerPaintTest.h:79: bool
m_originalSlimmingPaintInvalidationEnabled;
is this unrelated, why did this change in this patch?

https://codereview.chromium.org/2258523006/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp
(right):

https://codereview.chromium.org/2258523006/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp:38:
RuntimeEnabledFeatures::setRootLayerScrollingEnabled(m_originalRootLayerScrollingEnabled);
We do this manually in a lot of places?

https://codereview.chromium.org/2258523006/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp (right):

https://codereview.chromium.org/2258523006/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp:60:
RuntimeEnabledFeatures::setRootLayerScrollingEnabled(m_originalRootLayerScrollingEnabled);
more manual?

https://codereview.chromium.org/2258523006/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/tests/VisualViewportTest.cpp (left):

https://codereview.chromium.org/2258523006/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/tests/VisualViewportTest.cpp:203:
FrameTestHelpers::RootLayerScrollsSettingOverride));
this doesn't seem better to copy pasta this all over

https://codereview.chromium.org/2258523006/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/tests/VisualViewportTest.cpp (right):

https://codereview.chromium.org/2258523006/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/tests/VisualViewportTest.cpp:205: bool
m_enableRootLayerScrolling;
again

[trchen, 2016-08-26 00:04:12]

Description was changed from

==========
Convert Settings::rootLayerScrolls to RuntimeEnabledFeatures

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Convert Settings::rootLayerScrolls to RuntimeEnabledFeatures

Settings are sometimes difficult to get access to, depend on the context.
Also we don't find any use cases to applying different rootLayerScrolls value
to individual frames. Migrating to RuntimeEnabledFeatures to simplify code.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[trchen, 2016-08-26 00:15:11]

https://codereview.chromium.org/2258523006/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/PaintControllerPaintTest.h (left):

https://codereview.chromium.org/2258523006/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PaintControllerPaintTest.h:79: bool
m_originalSlimmingPaintInvalidationEnabled;
On 2016/08/25 23:59:24, esprehn wrote:
> is this unrelated, why did this change in this patch?

Yes, it is a drive-by change.

This flag wasn't toggled anywhere. Instead of save & restore it could be
converted into save & CHECK_EQ. I think we should simply clean it up.

https://codereview.chromium.org/2258523006/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp
(right):

https://codereview.chromium.org/2258523006/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp:38:
RuntimeEnabledFeatures::setRootLayerScrollingEnabled(m_originalRootLayerScrollingEnabled);
On 2016/08/25 23:59:24, esprehn wrote:
> We do this manually in a lot of places?

Good point. I was tired of this too. I can make it a RAII mix-in class.

[trchen, 2016-08-26 02:15:06]

REF test helpers added.

[trchen, 2016-08-26 02:15:25]

trchen@chromium.org changed reviewers:
- pdr@google.com

[trchen, 2016-08-26 03:43:15]

The CQ bit was checked by trchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 03:43:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[esprehn, 2016-08-26 04:46:49]

lgtm

[commit-bot: I haz the power, 2016-08-26 05:52:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 05:52:15]

Dry run: This issue passed the CQ dry run.

[trchen, 2016-08-26 20:55:22]

The CQ bit was checked by trchen@chromium.org

[trchen, 2016-08-26 20:55:23]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org,
skobes@chromium.org
Link to the patchset: https://codereview.chromium.org/2258523006/#ps40001
(title: "Add RAII-style helper to toggle REF. Rebase.")

[commit-bot: I haz the power, 2016-08-26 20:56:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 21:05:17]

Description was changed from

==========
Convert Settings::rootLayerScrolls to RuntimeEnabledFeatures

Settings are sometimes difficult to get access to, depend on the context.
Also we don't find any use cases to applying different rootLayerScrolls value
to individual frames. Migrating to RuntimeEnabledFeatures to simplify code.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Convert Settings::rootLayerScrolls to RuntimeEnabledFeatures

Settings are sometimes difficult to get access to, depend on the context.
Also we don't find any use cases to applying different rootLayerScrolls value
to individual frames. Migrating to RuntimeEnabledFeatures to simplify code.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[commit-bot: I haz the power, 2016-08-26 21:05:19]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-26 21:07:06]

Description was changed from

==========
Convert Settings::rootLayerScrolls to RuntimeEnabledFeatures

Settings are sometimes difficult to get access to, depend on the context.
Also we don't find any use cases to applying different rootLayerScrolls value
to individual frames. Migrating to RuntimeEnabledFeatures to simplify code.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Convert Settings::rootLayerScrolls to RuntimeEnabledFeatures

Settings are sometimes difficult to get access to, depend on the context.
Also we don't find any use cases to applying different rootLayerScrolls value
to individual frames. Migrating to RuntimeEnabledFeatures to simplify code.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/1d1f13a9f7961b2b891b858c769dc7f2b787e8f8
Cr-Commit-Position: refs/heads/master@{#414804}
==========

[commit-bot: I haz the power, 2016-08-26 21:07:08]

Patchset 3 (id:??) landed as
https://crrev.com/1d1f13a9f7961b2b891b858c769dc7f2b787e8f8
Cr-Commit-Position: refs/heads/master@{#414804}