third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp - Issue 2258523006: Convert Settings::rootLayerScrolls to RuntimeEnabledFeatures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp

Issue 2258523006: Convert Settings::rootLayerScrolls to RuntimeEnabledFeatures (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add RAII-style helper to toggle REF. Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintInvalidator.cpp ('k') | third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp b/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp

index 44553cf74390c80e71bbc69a508710e3cb462198..214c5beccd500073757151192bf0383e8f21fb45 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp

@@ -241,8 +241,7 @@ void PaintLayerClipper::calculateRects(const ClipRectsContext& context, const La

void PaintLayerClipper::calculateClipRects(const ClipRectsContext& context, ClipRects& clipRects) const

{

const LayoutBoxModelObject& layoutObject = *m_layer.layoutObject();

- bool rootLayerScrolls = layoutObject.document().settings() && layoutObject.document().settings()->rootLayerScrolls();

- if (!m_layer.parent() && !rootLayerScrolls) {

+ if (!m_layer.parent() && !RuntimeEnabledFeatures::rootLayerScrollingEnabled()) {

// The root layer's clip rect is always infinite.

clipRects.reset(LayoutRect(LayoutRect::infiniteIntRect()));

return;