Convert Settings::rootLayerScrolls to RuntimeEnabledFeatures

third_party/WebKit/Source/core/frame/FrameView.cpp

 /*
  * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
  *                     1999 Lars Knoll <knoll@kde.org>
  *                     1999 Antti Koivisto <koivisto@kde.org>
  *                     2000 Dirk Mueller <mueller@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  *           (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
@@ skipping 828 matching lines @@
         m_scrollAnchor.setScroller(scroller);
     }
 
     if (shouldPerformScrollAnchoring())
         m_scrollAnchor.save();
 }
 
 bool FrameView::shouldPerformScrollAnchoring() const
 {
     return RuntimeEnabledFeatures::scrollAnchoringEnabled()
-        && m_frame->settings() && !m_frame->settings()->rootLayerScrolls()
+        && !RuntimeEnabledFeatures::rootLayerScrollingEnabled()
         && m_scrollAnchor.hasScroller()
         && layoutBox()->style()->overflowAnchor() != AnchorNone;
 }
 
 static inline void layoutFromRootObject(LayoutObject& root)
 {
     LayoutState layoutState(root);
     root.layout();
 }
 
@@ skipping 283 matching lines @@
 #if ENABLE(ASSERT)
     layoutView()->assertSubtreeClearedPaintInvalidationFlags();
 #endif
 
     lifecycle().advanceTo(DocumentLifecycle::PaintInvalidationClean);
 }
 
 void FrameView::invalidatePaintIfNeeded(const PaintInvalidationState& paintInvalidationState)
 {
     RELEASE_ASSERT(!layoutViewItem().isNull());
-    if (!m_frame->settings() || !m_frame->settings()->rootLayerScrolls())
+    if (!RuntimeEnabledFeatures::rootLayerScrollingEnabled())
         invalidatePaintOfScrollControlsIfNeeded(paintInvalidationState);
 
     if (m_frame->selection().isCaretBoundsDirty())
         m_frame->selection().invalidateCaretRect();
 
     // Temporary callback for crbug.com/487345,402044
     // TODO(ojan): Make this more general to be used by PositionObserver
     // and rAF throttling.
     IntRect visibleRect = rootFrameToContents(computeVisibleArea());
     layoutViewItem().sendMediaPositionChangeNotifications(visibleRect);
@@ skipping 203 matching lines @@
 
         if (ScrollingCoordinator* scrollingCoordinator = this->scrollingCoordinator())
             scrollingCoordinator->frameViewFixedObjectsDidChange(this);
     }
 }
 
 void FrameView::viewportSizeChanged(bool widthChanged, bool heightChanged)
 {
     DCHECK(widthChanged || heightChanged);
 
-    if (m_frame->settings() && m_frame->settings()->rootLayerScrolls()) {
+    if (RuntimeEnabledFeatures::rootLayerScrollingEnabled()) {
         // The background must be repainted when the FrameView is resized, even if the initial
         // containing block does not change (so we can't rely on layout to issue the invalidation).
         // This is because the background fills the main GraphicsLayer, which takes the size of the
         // layout viewport.
         // TODO(skobes): Paint non-fixed backgrounds into the scrolling contents layer and avoid
         // this invalidation (http://crbug.com/568847).
         LayoutViewItem lvi = layoutViewItem();
         if (!lvi.isNull())
             lvi.setShouldDoFullPaintInvalidation();
     }
@@ skipping 642 matching lines @@
 
     // Scrolling is disabled during updateScrollbars (see isProgrammaticallyScrollable).
     // Bail now to avoid clearing m_fragmentAnchor before we actually have a chance to scroll.
     if (m_inUpdateScrollbars)
         return;
 
     if (anchorNode->layoutObject()) {
         LayoutRect rect;
         if (anchorNode != m_frame->document()) {
             rect = anchorNode->boundingBox();
-        } else if (m_frame->settings() && m_frame->settings()->rootLayerScrolls()) {
+        } else if (RuntimeEnabledFeatures::rootLayerScrollingEnabled()) {
             if (Element* documentElement = m_frame->document()->documentElement())
                 rect = documentElement->boundingBox();
         }
 
         Frame* boundaryFrame = m_frame->findUnsafeParentScrollPropagationBoundary();
 
         // FIXME: Handle RemoteFrames
         if (boundaryFrame && boundaryFrame->isLocalFrame())
             toLocalFrame(boundaryFrame)->view()->setSafeToPropagateScrollToParent(false);
 
@@ skipping 1361 matching lines @@
 {
     // TODO(skobes): We shouldn't have to clamp here; instead we should update callers
     // ScrollableArea::scrollPositionChanged to only pass clamped offsets.
     DoublePoint newPosition = clampScrollPosition(offset);
 
     DoublePoint oldPosition = m_scrollPosition;
     DoubleSize scrollDelta = newPosition - oldPosition;
     if (scrollDelta.isZero())
         return;
 
-    if (m_frame->settings() && m_frame->settings()->rootLayerScrolls()) {
+    if (RuntimeEnabledFeatures::rootLayerScrollingEnabled()) {
         // Don't scroll the FrameView!
         ASSERT_NOT_REACHED();
     }
 
     m_scrollPosition = newPosition;
 
     if (!scrollbarsSuppressed())
         m_pendingScrollDelta += scrollDelta;
 
     clearFragmentAnchor();
@@ skipping 52 matching lines @@
 }
 
 void FrameView::computeScrollbarExistence(bool& newHasHorizontalScrollbar, bool& newHasVerticalScrollbar, const IntSize& docSize, ComputeScrollbarExistenceOption option) const
 {
     bool hasHorizontalScrollbar = m_horizontalScrollbar;
     bool hasVerticalScrollbar = m_verticalScrollbar;
 
     newHasHorizontalScrollbar = hasHorizontalScrollbar;
     newHasVerticalScrollbar = hasVerticalScrollbar;
 
-    if (m_frame->settings() && m_frame->settings()->rootLayerScrolls())
+    if (RuntimeEnabledFeatures::rootLayerScrollingEnabled())
         return;
 
     ScrollbarMode hScroll = m_horizontalScrollbarMode;
     ScrollbarMode vScroll = m_verticalScrollbarMode;
 
     if (hScroll != ScrollbarAuto)
         newHasHorizontalScrollbar = (hScroll == ScrollbarAlwaysOn);
     if (vScroll != ScrollbarAuto)
         newHasVerticalScrollbar = (vScroll == ScrollbarAlwaysOn);
 
@@ skipping 142 matching lines @@
 void FrameView::updateScrollbarsIfNeeded()
 {
     if (m_needsScrollbarsUpdate || needsScrollbarReconstruction() || scrollOriginChanged())
         updateScrollbars();
 }
 
 void FrameView::updateScrollbars()
 {
     m_needsScrollbarsUpdate = false;
 
-    if (m_frame->settings() && m_frame->settings()->rootLayerScrolls())
+    if (RuntimeEnabledFeatures::rootLayerScrollingEnabled())
         return;
 
     // Avoid drawing two sets of scrollbars when visual viewport is enabled.
     if (visualViewportSuppliesScrollbars()) {
         setHasHorizontalScrollbar(false);
         setHasVerticalScrollbar(false);
         adjustScrollPositionFromUpdateScrollbars();
         return;
     }
 
@@ skipping 243 matching lines @@
     positionScrollCornerLayer(layerForScrollCorner(), scrollCornerRect());
 }
 
 bool FrameView::userInputScrollable(ScrollbarOrientation orientation) const
 {
     Document* document = frame().document();
     Element* fullscreenElement = Fullscreen::fullscreenElementFrom(*document);
     if (fullscreenElement && fullscreenElement != document->documentElement())
         return false;
 
-    if (frame().settings() && frame().settings()->rootLayerScrolls())
+    if (RuntimeEnabledFeatures::rootLayerScrollingEnabled())
         return false;
 
     ScrollbarMode mode = (orientation == HorizontalScrollbar) ?
         m_horizontalScrollbarMode : m_verticalScrollbarMode;
 
     return mode == ScrollbarAuto || mode == ScrollbarAlwaysOn;
 }
 
 bool FrameView::shouldPlaceVerticalScrollbarOnLeft() const
 {
@@ skipping 193 matching lines @@
 ScrollableArea* FrameView::getScrollableArea()
 {
     if (m_viewportScrollableArea)
         return m_viewportScrollableArea.get();
 
     return layoutViewportScrollableArea();
 }
 
 ScrollableArea* FrameView::layoutViewportScrollableArea()
 {
-    Settings* settings = frame().settings();
-    if (!settings || !settings->rootLayerScrolls())
+    if (!RuntimeEnabledFeatures::rootLayerScrollingEnabled())
         return this;
 
     LayoutViewItem layoutViewItem = this->layoutViewItem();
     return layoutViewItem.isNull() ? nullptr : layoutViewItem.getScrollableArea();
 }
 
 RootFrameViewport* FrameView::getRootFrameViewport()
 {
     return m_viewportScrollableArea.get();
 }
@@ skipping 175 matching lines @@
 }
 
 bool FrameView::canThrottleRendering() const
 {
     if (!RuntimeEnabledFeatures::renderingPipelineThrottlingEnabled())
         return false;
     return m_subtreeThrottled || (m_hiddenForThrottling && m_crossOriginForThrottling);
 }
 
 } // namespace blink