third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp - Issue 2258523006: Convert Settings::rootLayerScrolls to RuntimeEnabledFeatures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

Issue 2258523006: Convert Settings::rootLayerScrolls to RuntimeEnabledFeatures (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add RAII-style helper to toggle REF. Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp ('k') | third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

index 4f03f2696807dd4c33992714388dc38fc4f2cd14..6e69ff12431d04218adfed181f72b3fd629e333d 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

@@ -1573,13 +1573,10 @@ void CompositedLayerMapping::updateElementIdAndCompositorMutableProperties()

if (owningNode) {

Document& document = owningNode->document();

Element* scrollingElement = document.scrollingElement();

- LocalFrame* frame = document.frame();

- Settings* settings = frame ? frame->settings() : nullptr;

- bool rootLayerScrolls = settings && settings->rootLayerScrolls();

- if (owningNode->isElementNode() && (!rootLayerScrolls || owningNode != scrollingElement)) {

+ if (owningNode->isElementNode() && (!RuntimeEnabledFeatures::rootLayerScrollingEnabled() || owningNode != scrollingElement)) {

animatingElement = toElement(owningNode);

animatingStyle = m_owningLayer.layoutObject()->style();

- } else if (owningNode->isDocumentNode() && rootLayerScrolls) {

+ } else if (owningNode->isDocumentNode() && RuntimeEnabledFeatures::rootLayerScrollingEnabled()) {

owningNode = animatingElement = scrollingElement;

if (scrollingElement)

animatingStyle = scrollingElement->layoutObject()->style();