[Mac] Reworked FullscreenToolbarController

[Mac] Reworked FullscreenToolbarController

Removed mouse tracking for the menubar since it's unreliable
for multiple monitors and SplitScreen. Instead, use the menubar
Carbon events to update the toolbar.

Removed the animation delays because they were mostly unused.
When they actually were used, they would cause bugs and janky
movements. Cleaned up dead code and comments

BUG=634981, 637976, 637514
Committed: https://crrev.com/cccd612ee508dd2ee75f5d70e46b33bb17a7b88f
Cr-Commit-Position: refs/heads/master@{#413018}

[spqchan, 2016-08-18 01:05:35]

Description was changed from

==========
[Mac] Reworked FullscreenToolbarController

Remove mouse tracking at the top. Instead check if the menubar had been
revealed for the correct screen

BUG=
==========

to

==========
[Mac] Reworked FullscreenToolbarController

Remove mouse tracking for the menubar since it's unreliable. Instead, the
menubar reveal events will update the toolbar. Removed the animation delays
because they have been causing bugs and
janky movements 


BUG=634981, 637976
==========

[spqchan, 2016-08-18 19:11:12]

Description was changed from

==========
[Mac] Reworked FullscreenToolbarController

Remove mouse tracking for the menubar since it's unreliable. Instead, the
menubar reveal events will update the toolbar. Removed the animation delays
because they have been causing bugs and
janky movements 


BUG=634981, 637976
==========

to

==========
[Mac] Reworked FullscreenToolbarController

Remove mouse tracking for the menubar since it's unreliable. Instead, use the
menubar Carbon events to update the toolbar. 

Removed the animation delays because they have been causing bugs and janky
movements. Cleaned up dead code and comments

BUG=634981, 637976
==========

[spqchan, 2016-08-18 19:11:35]

Description was changed from

==========
[Mac] Reworked FullscreenToolbarController

Remove mouse tracking for the menubar since it's unreliable. Instead, use the
menubar Carbon events to update the toolbar. 

Removed the animation delays because they have been causing bugs and janky
movements. Cleaned up dead code and comments

BUG=634981, 637976
==========

to

==========
[Mac] Reworked FullscreenToolbarController

Remove mouse tracking for the menubar since it's unreliable. Instead,
use the menubar Carbon events to update the toolbar. 

Removed the animation delays because they have been causing bugs
and janky movements. Cleaned up dead code and comments

BUG=634981, 637976
==========

[spqchan, 2016-08-18 19:11:47]

Description was changed from

==========
[Mac] Reworked FullscreenToolbarController

Remove mouse tracking for the menubar since it's unreliable. Instead,
use the menubar Carbon events to update the toolbar. 

Removed the animation delays because they have been causing bugs
and janky movements. Cleaned up dead code and comments

BUG=634981, 637976
==========

to

==========
[Mac] Reworked FullscreenToolbarController

Removed mouse tracking for the menubar since it's unreliable. Instead,
use the menubar Carbon events to update the toolbar. 

Removed the animation delays because they have been causing bugs
and janky movements. Cleaned up dead code and comments

BUG=634981, 637976
==========

[spqchan, 2016-08-18 19:13:25]

Description was changed from

==========
[Mac] Reworked FullscreenToolbarController

Removed mouse tracking for the menubar since it's unreliable. Instead,
use the menubar Carbon events to update the toolbar. 

Removed the animation delays because they have been causing bugs
and janky movements. Cleaned up dead code and comments

BUG=634981, 637976
==========

to

==========
[Mac] Reworked FullscreenToolbarController

Removed mouse tracking for the menubar since it's unreliable. Instead,
use the menubar Carbon events to update the toolbar. 

Removed the animation delays because they were mostly unused. When they actually
were used, they would cause bugs and janky
movements. Cleaned up dead code and comments

BUG=634981, 637976
==========

[spqchan, 2016-08-18 19:13:50]

Description was changed from

==========
[Mac] Reworked FullscreenToolbarController

Removed mouse tracking for the menubar since it's unreliable. Instead,
use the menubar Carbon events to update the toolbar. 

Removed the animation delays because they were mostly unused. When they actually
were used, they would cause bugs and janky
movements. Cleaned up dead code and comments

BUG=634981, 637976
==========

to

==========
[Mac] Reworked FullscreenToolbarController

Removed mouse tracking for the menubar since it's unreliable. Instead,
use the menubar Carbon events to update the toolbar. 

Removed the animation delays because they were mostly unused. When
they actually were used, they would cause bugs and janky
movements. Cleaned up dead code and comments

BUG=634981, 637976
==========

[spqchan, 2016-08-18 19:14:08]

Description was changed from

==========
[Mac] Reworked FullscreenToolbarController

Removed mouse tracking for the menubar since it's unreliable. Instead,
use the menubar Carbon events to update the toolbar. 

Removed the animation delays because they were mostly unused. When
they actually were used, they would cause bugs and janky
movements. Cleaned up dead code and comments

BUG=634981, 637976
==========

to

==========
[Mac] Reworked FullscreenToolbarController

Removed mouse tracking for the menubar since it's unreliable.
Instead, use the menubar Carbon events to update the toolbar. 

Removed the animation delays because they were mostly unused.
When they actually were used, they would cause bugs and janky
movements. Cleaned up dead code and comments

BUG=634981, 637976
==========

[spqchan, 2016-08-18 19:14:27]

spqchan@chromium.org changed reviewers:
+ erikchen@chromium.org

[spqchan, 2016-08-18 19:15:16]

Description was changed from

==========
[Mac] Reworked FullscreenToolbarController

Removed mouse tracking for the menubar since it's unreliable.
Instead, use the menubar Carbon events to update the toolbar. 

Removed the animation delays because they were mostly unused.
When they actually were used, they would cause bugs and janky
movements. Cleaned up dead code and comments

BUG=634981, 637976
==========

to

==========
[Mac] Reworked FullscreenToolbarController

Removed mouse tracking for the menubar since it's unreliable
for multiple monitors and SplitScreen. Instead, use the menubar
Carbon events to update the toolbar. 

Removed the animation delays because they were mostly unused.
When they actually were used, they would cause bugs and janky
movements. Cleaned up dead code and comments

BUG=634981, 637976
==========

[spqchan, 2016-08-18 19:15:51]

PTAL

[erikchen, 2016-08-18 19:33:47]

nice work, this is a lot simpler than before!

I tested this out on 10.11, and everything worked smooth as butter.

https://codereview.chromium.org/2256993002/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/fullscreen_toolbar_controller.mm (right):

https://codereview.chromium.org/2256993002/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/fullscreen_toolbar_controller.mm:263: [self
changeOverlayToFraction:1 withAnimation:YES];
maybe just [self changeOverlayToFraction:1 withAnimation:animate];

ditto for the hide.

https://codereview.chromium.org/2256993002/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/fullscreen_toolbar_controller.mm:388: toolbarFraction_ =
progress;
I don't understand why we didn't need this before. Was that a bug?

[spqchan, 2016-08-18 19:55:58]

thanks! PTAL

https://codereview.chromium.org/2256993002/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/fullscreen_toolbar_controller.mm (right):

https://codereview.chromium.org/2256993002/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/fullscreen_toolbar_controller.mm:263: [self
changeOverlayToFraction:1 withAnimation:YES];
On 2016/08/18 19:33:47, erikchen wrote:
> maybe just [self changeOverlayToFraction:1 withAnimation:animate];
> 
> ditto for the hide.

Done.

https://codereview.chromium.org/2256993002/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/fullscreen_toolbar_controller.mm:388: toolbarFraction_ =
progress;
On 2016/08/18 19:33:47, erikchen wrote:
> I don't understand why we didn't need this before. Was that a bug?

Yeah, it was pretty confusing. |toolbarFraction_| was only set by the
DropdownAnimation, which was kickstarted by mouse events.

Since we now rely on the Carbon events, DropdownAnimation is no longer necessary
for the menubar drops and we can set the fraction directly here.

[erikchen, 2016-08-18 19:58:09]

lgtm

[spqchan, 2016-08-18 20:45:18]

spqchan@chromium.org changed reviewers:
+ avi@chromium.org

[spqchan, 2016-08-18 20:45:19]

+avi for OWNERS

[spqchan, 2016-08-18 22:32:57]

Description was changed from

==========
[Mac] Reworked FullscreenToolbarController

Removed mouse tracking for the menubar since it's unreliable
for multiple monitors and SplitScreen. Instead, use the menubar
Carbon events to update the toolbar. 

Removed the animation delays because they were mostly unused.
When they actually were used, they would cause bugs and janky
movements. Cleaned up dead code and comments

BUG=634981, 637976
==========

to

==========
[Mac] Reworked FullscreenToolbarController

Removed mouse tracking for the menubar since it's unreliable
for multiple monitors and SplitScreen. Instead, use the menubar
Carbon events to update the toolbar. 

Removed the animation delays because they were mostly unused.
When they actually were used, they would cause bugs and janky
movements. Cleaned up dead code and comments

BUG=634981, 637976, 637514
==========

[Avi (use Gerrit), 2016-08-19 00:10:06]

stampity stamp

LGTM

[spqchan, 2016-08-19 00:12:25]

On 2016/08/19 00:10:06, Avi wrote:
> stampity stamp
> 
> LGTM

thanks!

[spqchan, 2016-08-19 00:12:31]

The CQ bit was checked by spqchan@chromium.org

[commit-bot: I haz the power, 2016-08-19 00:13:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 01:47:08]

Description was changed from

==========
[Mac] Reworked FullscreenToolbarController

Removed mouse tracking for the menubar since it's unreliable
for multiple monitors and SplitScreen. Instead, use the menubar
Carbon events to update the toolbar. 

Removed the animation delays because they were mostly unused.
When they actually were used, they would cause bugs and janky
movements. Cleaned up dead code and comments

BUG=634981, 637976, 637514
==========

to

==========
[Mac] Reworked FullscreenToolbarController

Removed mouse tracking for the menubar since it's unreliable
for multiple monitors and SplitScreen. Instead, use the menubar
Carbon events to update the toolbar. 

Removed the animation delays because they were mostly unused.
When they actually were used, they would cause bugs and janky
movements. Cleaned up dead code and comments

BUG=634981, 637976, 637514
==========

[commit-bot: I haz the power, 2016-08-19 01:47:09]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-19 01:49:47]

Description was changed from

==========
[Mac] Reworked FullscreenToolbarController

Removed mouse tracking for the menubar since it's unreliable
for multiple monitors and SplitScreen. Instead, use the menubar
Carbon events to update the toolbar. 

Removed the animation delays because they were mostly unused.
When they actually were used, they would cause bugs and janky
movements. Cleaned up dead code and comments

BUG=634981, 637976, 637514
==========

to

==========
[Mac] Reworked FullscreenToolbarController

Removed mouse tracking for the menubar since it's unreliable
for multiple monitors and SplitScreen. Instead, use the menubar
Carbon events to update the toolbar.

Removed the animation delays because they were mostly unused.
When they actually were used, they would cause bugs and janky
movements. Cleaned up dead code and comments

BUG=634981, 637976, 637514

Committed: https://crrev.com/cccd612ee508dd2ee75f5d70e46b33bb17a7b88f
Cr-Commit-Position: refs/heads/master@{#413018}
==========

[commit-bot: I haz the power, 2016-08-19 01:49:48]

Patchset 4 (id:??) landed as
https://crrev.com/cccd612ee508dd2ee75f5d70e46b33bb17a7b88f
Cr-Commit-Position: refs/heads/master@{#413018}