Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 2256993002: [Mac] Reworked FullscreenToolbarController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix for erikchen Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_controller.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm
index 866ad49d5d10054f7f467351e6ddf2c5c367a0a1..7526dfab7fc0b4cdd8e14626161cb70dec198e1c 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm
@@ -1984,24 +1984,19 @@ willAnimateFromState:(BookmarkBar::State)oldState
return [barVisibilityLocks_ containsObject:owner];
}
-- (void)lockBarVisibilityForOwner:(id)owner
- withAnimation:(BOOL)animate
- delay:(BOOL)delay {
+- (void)lockBarVisibilityForOwner:(id)owner withAnimation:(BOOL)animate {
if (![self isBarVisibilityLockedForOwner:owner]) {
[barVisibilityLocks_ addObject:owner];
// If enabled, show the overlay if necessary (and if the fullscreen
// toolbar is hidden).
if (barVisibilityUpdatesEnabled_) {
- [fullscreenToolbarController_ ensureOverlayShownWithAnimation:animate
- delay:delay];
+ [fullscreenToolbarController_ ensureOverlayShownWithAnimation:animate];
}
}
}
-- (void)releaseBarVisibilityForOwner:(id)owner
- withAnimation:(BOOL)animate
- delay:(BOOL)delay {
+- (void)releaseBarVisibilityForOwner:(id)owner withAnimation:(BOOL)animate {
if ([self isBarVisibilityLockedForOwner:owner]) {
[barVisibilityLocks_ removeObject:owner];
@@ -2009,8 +2004,7 @@ willAnimateFromState:(BookmarkBar::State)oldState
// toolbar is hidden).
if (barVisibilityUpdatesEnabled_ &&
![barVisibilityLocks_ count]) {
- [fullscreenToolbarController_ ensureOverlayHiddenWithAnimation:animate
- delay:delay];
+ [fullscreenToolbarController_ ensureOverlayHiddenWithAnimation:animate];
}
}
}
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller.h ('k') | chrome/browser/ui/cocoa/browser_window_controller_private.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698