chrome/browser/ui/cocoa/global_error_bubble_controller.mm - Issue 2256993002: [Mac] Reworked FullscreenToolbarController

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/global_error_bubble_controller.mm

Issue 2256993002: [Mac] Reworked FullscreenToolbarController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix for erikchen Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/global_error_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/global_error_bubble_controller.mm b/chrome/browser/ui/cocoa/global_error_bubble_controller.mm

index 14c05cba4fce69cc36d27122073a1d12459f30b0..a4153e8e42a158895b849108ace96e6f35f0e81a 100644

--- a/chrome/browser/ui/cocoa/global_error_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/global_error_bubble_controller.mm

@@ -127,7 +127,7 @@ class Bridge : public GlobalErrorBubbleViewBase {

- (void)showWindow:(id)sender {

BrowserWindowController* bwc = [BrowserWindowController

browserWindowControllerForWindow:[self parentWindow]];

- [bwc lockBarVisibilityForOwner:self withAnimation:NO delay:NO];

+ [bwc lockBarVisibilityForOwner:self withAnimation:NO];

[super showWindow:sender];

}

@@ -137,7 +137,7 @@ class Bridge : public GlobalErrorBubbleViewBase {

bridge_.reset();

BrowserWindowController* bwc = [BrowserWindowController

browserWindowControllerForWindow:[self parentWindow]];

- [bwc releaseBarVisibilityForOwner:self withAnimation:YES delay:NO];

+ [bwc releaseBarVisibilityForOwner:self withAnimation:YES];

[super close];

}