chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm - Issue 2256993002: [Mac] Reworked FullscreenToolbarController

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm

Issue 2256993002: [Mac] Reworked FullscreenToolbarController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix for erikchen Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm ('k') | chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm

diff --git a/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm b/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm

index 633e5cf09e7038bcbf0ce9299be1b7e2a49721e5..b4f6d71e8283aa11dec1ab506ea2094795e8f39b 100644

--- a/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm

+++ b/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm

@@ -324,7 +324,8 @@ BOOL ThePasteboardIsTooDamnBig() {

// responder dance between the field and the field editor is a little

// weird.)

[[BrowserWindowController browserWindowControllerForView:field]

- lockBarVisibilityForOwner:field withAnimation:YES delay:NO];

+ lockBarVisibilityForOwner:field

+ withAnimation:YES];

}

return doAccept;

}

@@ -337,7 +338,8 @@ BOOL ThePasteboardIsTooDamnBig() {

if (doResign && field) {

// Give the text field ownership of the visibility lock.

[[BrowserWindowController browserWindowControllerForView:field]

- releaseBarVisibilityForOwner:field withAnimation:YES delay:YES];

+ releaseBarVisibilityForOwner:field

+ withAnimation:YES];

AutocompleteTextFieldObserver* observer = [self observer];

if (observer)