chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_observer_cocoa.mm - Issue 2256993002: [Mac] Reworked FullscreenToolbarController

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_observer_cocoa.mm

Issue 2256993002: [Mac] Reworked FullscreenToolbarController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix for erikchen Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_observer_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_observer_cocoa.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_observer_cocoa.mm

index 34bfca5fc279ff7c4e3b753041140456ff5004a8..20bd25c69afbb7b0cb4e91bfec97c9e273ce18e0 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_observer_cocoa.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_observer_cocoa.mm

@@ -17,14 +17,12 @@ BookmarkBubbleObserverCocoa::~BookmarkBubbleObserverCocoa() {}

void BookmarkBubbleObserverCocoa::OnBookmarkBubbleShown(

const bookmarks::BookmarkNode* node) {

- [controller_ lockBarVisibilityForOwner:lockOwner_ withAnimation:NO delay:NO];

+ [controller_ lockBarVisibilityForOwner:lockOwner_ withAnimation:NO];

[[controller_ bookmarkBarController] startPulsingBookmarkNode:node];

}

void BookmarkBubbleObserverCocoa::OnBookmarkBubbleHidden() {

- [controller_ releaseBarVisibilityForOwner:lockOwner_

- withAnimation:YES

- delay:NO];

+ [controller_ releaseBarVisibilityForOwner:lockOwner_ withAnimation:YES];

[[controller_ bookmarkBarController] stopPulsingBookmarkNode];

[controller_ bookmarkBubbleClosed];

}