Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2256363002: Attempt to remove non-namespaced base::Version usage. (Closed)

Created:
4 years, 4 months ago by pwnall
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, grt+watch_chromium.org, jam, piman+watch_chromium.org, pennymac+watch_chromium.org, darin-cc_chromium.org, asvitkine+watch_chromium.org, wfh+watch_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Attempt to remove non-namespaced base::Version usage. BUG=639416 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Patch Set 1 : Rebased against master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+386 lines, -377 lines) Patch
M base/version.h View 1 chunk +0 lines, -4 lines 0 comments Download
M base/version_unittest.cc View 6 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/chrome_browser_main_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/app_mode/startup_app_launcher.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/kiosk_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/component_installers_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/pnacl_component_installer.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/component_updater/recovery_component_installer.cc View 8 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/component_updater/sw_reporter_installer_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/swiftshader_component_installer.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/chrome_extensions_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_management_internal.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 19 chunks +36 lines, -33 lines 0 comments Download
M chrome/browser/extensions/extension_sync_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_sync_data_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/external_policy_loader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/external_provider_impl.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/extensions/external_registry_loader_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/pending_extension_info.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/pending_extension_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/pending_extension_manager.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/unpacked_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/updater/extension_updater_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/updater/local_extension_cache.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/webstore_installer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/webstore_installer.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/crl_set_fetcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/plugins/plugin_finder.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugins/plugin_metadata.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/plugins/plugin_metadata.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/plugins/plugin_metadata_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/startup/default_browser_prompt.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/upgrade_detector_impl.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/win/enumerate_modules_model.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/chrome_content_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/pepper_flash.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/service_process_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/service_process_util_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/setup/install.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/setup/install.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/installer/setup/install_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/setup/install_worker.cc View 11 chunks +16 lines, -16 lines 0 comments Download
M chrome/installer/setup/install_worker_unittest.cc View 8 chunks +10 lines, -10 lines 0 comments Download
M chrome/installer/setup/setup_main.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/setup/setup_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/setup_util.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/installer/setup/setup_util_unittest.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M chrome/installer/setup/uninstall.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/test/alternate_version_generator.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/util/browser_distribution.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/browser_distribution.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/fake_installation_state.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/installer/util/fake_product_state.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/google_chrome_distribution.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/google_chrome_distribution.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/google_update_settings.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/google_update_settings.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/installer/util/google_update_settings_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/install_util.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/installer/util/installation_state.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/util/installation_state.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/installer/util/installation_validator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/installer_state.cc View 9 chunks +16 lines, -15 lines 0 comments Download
M chrome/installer/util/installer_state_unittest.cc View 15 chunks +34 lines, -33 lines 0 comments Download
M chrome/installer/util/product_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/component_updater/component_updater_service_unittest.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M components/component_updater/default_component_installer_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/update_client/action_update_check.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M components/update_client/crx_update_item.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/update_client/test_installer.h View 1 chunk +1 line, -1 line 0 comments Download
M components/update_client/test_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/update_client/update_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/update_client/update_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/update_client/update_client_internal.h View 1 chunk +1 line, -1 line 0 comments Download
M components/update_client/update_client_unittest.cc View 12 chunks +18 lines, -18 lines 0 comments Download
M components/update_client/update_response.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/variations/processed_study.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/variations/study_filtering_unittest.cc View 3 chunks +8 lines, -10 lines 0 comments Download
M content/browser/plugin_data_remover_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/webplugininfo_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/webplugininfo.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/runtime/runtime_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/updater/extension_downloader.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M extensions/browser/updater/update_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/updater/update_service_unittest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M extensions/browser/user_script_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/manifest_handlers/shared_module_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/update_manifest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/config/gpu_info.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/config/gpu_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/config/gpu_info_collector_win.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M ios/chrome/browser/net/crl_set_fetcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 40 (39 generated)
pwnall
4 years, 3 months ago (2016-09-02 21:33:50 UTC) #39
Message was sent while issue was closed.
I broke this CL down in many pieces and landed them separately. The whole story
is in http://crbug.com/639416

Powered by Google App Engine
This is Rietveld 408576698