chrome/browser/component_updater/component_installers_unittest.cc - Issue 2256363002: Attempt to remove non-namespaced base::Version usage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/component_installers_unittest.cc

Issue 2256363002: Attempt to remove non-namespaced base::Version usage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased against master. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/kiosk_browsertest.cc ('k') | chrome/browser/component_updater/pnacl_component_installer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/component_updater/component_installers_unittest.cc

diff --git a/chrome/browser/component_updater/component_installers_unittest.cc b/chrome/browser/component_updater/component_installers_unittest.cc

index aefce5ff205e52490a809b27eadc25002ce1d8e6..a15272b5dcd93d9dc1dca5c9486a6e8d979e0351 100644

--- a/chrome/browser/component_updater/component_installers_unittest.cc

+++ b/chrome/browser/component_updater/component_installers_unittest.cc

@@ -82,7 +82,7 @@ TEST(ComponentInstallerTest, PepperFlashCheck) {

ASSERT_TRUE(root->IsType(base::Value::TYPE_DICTIONARY));

// This checks that the whole manifest is compatible.

- Version version;

+ base::Version version;

EXPECT_TRUE(chrome::CheckPepperFlashManifest(*root, &version));

EXPECT_TRUE(version.IsValid());

}