chrome/common/pepper_flash.cc - Issue 2256363002: Attempt to remove non-namespaced base::Version usage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/pepper_flash.cc

Issue 2256363002: Attempt to remove non-namespaced base::Version usage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased against master. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc ('k') | chrome/common/service_process_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/pepper_flash.cc

diff --git a/chrome/common/pepper_flash.cc b/chrome/common/pepper_flash.cc

index cad919947ea4b0f1de6a064de174363a56b38ac5..7eb5ae15085c33c9d1cb8af990e82354fc20076e 100644

--- a/chrome/common/pepper_flash.cc

+++ b/chrome/common/pepper_flash.cc

@@ -95,7 +95,7 @@ bool CheckPepperFlashInterfaces(const base::DictionaryValue& manifest) {

} // namespace

bool CheckPepperFlashManifest(const base::DictionaryValue& manifest,

- Version* version_out) {

+ base::Version* version_out) {

std::string name;

manifest.GetStringASCII("name", &name);

// TODO(viettrungluu): Support WinFlapper for now, while we change the format

@@ -106,7 +106,7 @@ bool CheckPepperFlashManifest(const base::DictionaryValue& manifest,

std::string proposed_version;

manifest.GetStringASCII("version", &proposed_version);

- Version version(proposed_version.c_str());

+ base::Version version(proposed_version.c_str());

if (!version.IsValid())

return false;