chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc - Issue 2256363002: Attempt to remove non-namespaced base::Version usage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc

Issue 2256363002: Attempt to remove non-namespaced base::Version usage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased against master. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc

diff --git a/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc b/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc

index b1af95d46c49e1f16df919098bf4be74ca4560cc..8cec59dc7d5611d09e067cdbc8569bf6a37b77ec 100644

--- a/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc

+++ b/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc

@@ -170,7 +170,7 @@ void RecordStartupMetricsOnBlockingPool() {

void RecordLinuxGlibcVersion() {

#if defined(OS_LINUX) && !defined(OS_CHROMEOS)

- Version version(gnu_get_libc_version());

+ base::Version version(gnu_get_libc_version());

UMALinuxGlibcVersion glibc_version_result = UMA_LINUX_GLIBC_NOT_PARSEABLE;

if (version.IsValid() && version.components().size() == 2) {

« no previous file with comments | « chrome/browser/extensions/webstore_installer.cc ('k') | chrome/browser/net/crl_set_fetcher.cc » ('j') | no next file with comments »