chrome/browser/win/enumerate_modules_model.cc - Issue 2256363002: Attempt to remove non-namespaced base::Version usage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/win/enumerate_modules_model.cc

Issue 2256363002: Attempt to remove non-namespaced base::Version usage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased against master. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/win/enumerate_modules_model.cc

diff --git a/chrome/browser/win/enumerate_modules_model.cc b/chrome/browser/win/enumerate_modules_model.cc

index 7c74cf4511c6e4e8e486093751ba457bdcad9e58..9954cce6d4ddbf1da655a5c929a066eae967175e 100644

--- a/chrome/browser/win/enumerate_modules_model.cc

+++ b/chrome/browser/win/enumerate_modules_model.cc

@@ -417,9 +417,9 @@ ModuleEnumerator::ModuleStatus ModuleEnumerator::Match(

location_hash == blacklisted.location)) {

// We have a name match against the blacklist (and possibly location match

// also), so check version.

- Version module_version(base::UTF16ToASCII(module.version));

- Version version_min(blacklisted.version_from);

- Version version_max(blacklisted.version_to);

+ base::Version module_version(base::UTF16ToASCII(module.version));

+ base::Version version_min(blacklisted.version_from);

+ base::Version version_max(blacklisted.version_to);

bool version_ok = !version_min.IsValid() && !version_max.IsValid();

if (!version_ok) {

bool too_low = version_min.IsValid() &&

« no previous file with comments | « chrome/browser/upgrade_detector_impl.cc ('k') | chrome/common/chrome_content_client.cc » ('j') | no next file with comments »