[MD History] Add shadow to toolbar on scroll.

[MD History] Add shadow to toolbar on scroll.

This CL adds the IronScrollTargetBehavior to history-app so that it can
listen to scroll events from the currently active history view and
render a shadow beneath the toolbar when the scroll isn't at the top.

BUG=638114
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/cb8aa763196dbb73c7aa724bd3bc7374a2a540a7
Cr-Commit-Position: refs/heads/master@{#414048}

[calamity, 2016-08-18 07:33:47]

Description was changed from

==========
[MD History] Add shadow to toolbar on scroll.

This CL adds the IronScrollTargetBehavior to history-app so that it can
listen to scroll events from the currently active history view and
render a shadow beneath the toolbar when the scroll isn't at the top.

BUG=638114
==========

to

==========
[MD History] Add shadow to toolbar on scroll.

This CL adds the IronScrollTargetBehavior to history-app so that it can
listen to scroll events from the currently active history view and
render a shadow beneath the toolbar when the scroll isn't at the top.

BUG=638114
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[calamity, 2016-08-19 06:57:58]

Patchset #1 (id:1) has been deleted

[calamity, 2016-08-19 08:25:12]

Patchset #1 (id:20001) has been deleted

[calamity, 2016-08-19 08:26:16]

calamity@chromium.org changed reviewers:
+ tsergeant@chromium.org

[tsergeant, 2016-08-22 00:45:03]

lgtm

https://codereview.chromium.org/2253083003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_history/list_container.js (right):

https://codereview.chromium.org/2253083003/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/list_container.js:98:
getContentScrollTarget: function() {
Nit: @return annotation

https://codereview.chromium.org/2253083003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_history/synced_device_manager.js (right):

https://codereview.chromium.org/2253083003/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/synced_device_manager.js:77:
getContentScrollTarget: function() { return this; },
Nit: @return annotation

[Dan Beam, 2016-08-23 00:15:24]

did we re-use anything from <paper-header-panel mode="waterfall">?

https://elements.polymer-project.org/elements/paper-header-panel?view=demo:de...

https://codereview.chromium.org/2253083003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_history/app.js (right):

https://codereview.chromium.org/2253083003/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/app.js:129: this.toolbarShadow_ =
(this.scrollTarget.scrollTop != 0);
nit: () aren't necessary

https://codereview.chromium.org/2253083003/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/app.js:308: 
nit: /** @private */

[calamity, 2016-08-23 03:19:54]

On 2016/08/23 00:15:24, Dan Beam wrote:
> did we re-use anything from <paper-header-panel mode="waterfall">?
> 
>
https://elements.polymer-project.org/elements/paper-header-panel?view=demo:de...
> 

Stole the CSS. You can't set the scrollTarget with paper-header-panel though =(

[calamity, 2016-08-23 03:23:32]

https://codereview.chromium.org/2253083003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_history/app.js (right):

https://codereview.chromium.org/2253083003/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/app.js:129: this.toolbarShadow_ =
(this.scrollTarget.scrollTop != 0);
On 2016/08/23 00:15:24, Dan Beam wrote:
> nit: () aren't necessary

Done.

https://codereview.chromium.org/2253083003/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/app.js:308: 
On 2016/08/23 00:15:24, Dan Beam wrote:
> nit: /** @private */

Done.

https://codereview.chromium.org/2253083003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_history/list_container.js (right):

https://codereview.chromium.org/2253083003/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/list_container.js:98:
getContentScrollTarget: function() {
On 2016/08/22 00:45:02, tsergeant wrote:
> Nit: @return annotation

Done.

https://codereview.chromium.org/2253083003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_history/synced_device_manager.js (right):

https://codereview.chromium.org/2253083003/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/synced_device_manager.js:77:
getContentScrollTarget: function() { return this; },
On 2016/08/22 00:45:02, tsergeant wrote:
> Nit: @return annotation

Done.

[calamity, 2016-08-23 03:23:53]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 03:24:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 03:30:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 03:30:54]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[calamity, 2016-08-23 04:50:36]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 04:50:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 07:52:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 07:52:55]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[calamity, 2016-08-24 05:20:02]

The CQ bit was checked by calamity@chromium.org

[calamity, 2016-08-24 05:20:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org
Link to the patchset: https://codereview.chromium.org/2253083003/#ps80001
(title: "fix_test?")

[commit-bot: I haz the power, 2016-08-24 05:20:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 05:23:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 05:23:22]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[calamity, 2016-08-24 05:46:57]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 05:47:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 08:07:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 08:07:41]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2016-08-24 11:47:45]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2016-08-24 11:47:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org
Link to the patchset: https://codereview.chromium.org/2253083003/#ps90001
(title: "rebase")

[commit-bot: I haz the power, 2016-08-24 11:48:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 11:51:58]

Committed patchset #4 (id:90001)

[commit-bot: I haz the power, 2016-08-24 11:54:47]

Description was changed from

==========
[MD History] Add shadow to toolbar on scroll.

This CL adds the IronScrollTargetBehavior to history-app so that it can
listen to scroll events from the currently active history view and
render a shadow beneath the toolbar when the scroll isn't at the top.

BUG=638114
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD History] Add shadow to toolbar on scroll.

This CL adds the IronScrollTargetBehavior to history-app so that it can
listen to scroll events from the currently active history view and
render a shadow beneath the toolbar when the scroll isn't at the top.

BUG=638114
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/cb8aa763196dbb73c7aa724bd3bc7374a2a540a7
Cr-Commit-Position: refs/heads/master@{#414048}
==========

[commit-bot: I haz the power, 2016-08-24 11:54:48]

Patchset 4 (id:??) landed as
https://crrev.com/cb8aa763196dbb73c7aa724bd3bc7374a2a540a7
Cr-Commit-Position: refs/heads/master@{#414048}