Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 2262123002: [MD History] Small accessibility fixes. (Closed)

Created:
4 years, 4 months ago by calamity
Modified:
4 years, 3 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@toolbar_shadow
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD History] Small accessibility fixes. This CL adds a title to the toolbar cancel button and an aria-label to the history-item checkbox. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/4dd7735f1f1b65ce876d277b4b8851011da76476 Cr-Commit-Position: refs/heads/master@{#416483}

Patch Set 1 #

Patch Set 2 : use entry summary string #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -4 lines) Patch
M chrome/browser/resources/md_history/app.crisper.js View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_history/app.vulcanized.html View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_history/history_item.html View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/md_history/history_item.js View 1 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_history/history_toolbar.html View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/md_history_ui.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 31 (19 generated)
calamity
4 years, 4 months ago (2016-08-23 04:55:31 UTC) #3
tsergeant
lgtm
4 years, 4 months ago (2016-08-23 05:22:18 UTC) #4
commit-bot: I haz the power
This CL has an open dependency (Issue 2253083003 Patch 40001). Please resolve the dependency and ...
4 years, 4 months ago (2016-08-23 05:24:14 UTC) #7
calamity
4 years, 3 months ago (2016-08-25 05:08:34 UTC) #8
tsergeant
lgtm
4 years, 3 months ago (2016-08-25 05:22:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2262123002/20001
4 years, 3 months ago (2016-08-29 05:59:55 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/286365)
4 years, 3 months ago (2016-08-29 06:46:27 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2262123002/40001
4 years, 3 months ago (2016-09-02 03:51:36 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: closure_compilation on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compilation/builds/2368)
4 years, 3 months ago (2016-09-02 04:01:49 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2262123002/40001
4 years, 3 months ago (2016-09-04 23:55:32 UTC) #28
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-05 00:59:29 UTC) #29
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 01:01:41 UTC) #31
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4dd7735f1f1b65ce876d277b4b8851011da76476
Cr-Commit-Position: refs/heads/master@{#416483}

Powered by Google App Engine
This is Rietveld 408576698