Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1420)

Issue 2271583009: [MD History] Disable toolbar shadow test. (Closed)

Created:
4 years, 3 months ago by calamity
Modified:
4 years, 3 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@toolbar_shadow
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD History] Disable toolbar shadow test. This CL disables the toolbar shadow test because it's flaky. This will be reenabled after investigation. BUG=640862 Committed: https://crrev.com/62514ae903a294ca3f3075b0f8c452d53d02da0a Cr-Commit-Position: refs/heads/master@{#414673}

Patch Set 1 #

Total comments: 1

Patch Set 2 : change to disable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/test/data/webui/md_history/history_list_test.js View 1 1 chunk +4 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (6 generated)
calamity
4 years, 3 months ago (2016-08-26 03:28:42 UTC) #2
tsergeant
https://codereview.chromium.org/2271583009/diff/1/chrome/test/data/webui/md_history/history_list_test.js File chrome/test/data/webui/md_history/history_list_test.js (left): https://codereview.chromium.org/2271583009/diff/1/chrome/test/data/webui/md_history/history_list_test.js#oldcode304 chrome/test/data/webui/md_history/history_list_test.js:304: test('scrolling history list causes toolbar shadow to appear', () ...
4 years, 3 months ago (2016-08-26 04:03:29 UTC) #3
calamity
Good catch. Done.
4 years, 3 months ago (2016-08-26 06:13:54 UTC) #6
tsergeant
lgtm
4 years, 3 months ago (2016-08-26 06:41:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2271583009/20001
4 years, 3 months ago (2016-08-26 06:41:58 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-26 08:47:32 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 08:50:08 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/62514ae903a294ca3f3075b0f8c452d53d02da0a
Cr-Commit-Position: refs/heads/master@{#414673}

Powered by Google App Engine
This is Rietveld 408576698