Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2278383002: [MD History] Use box-shadow to render card shadows everywhere. (Closed)

Created:
4 years, 3 months ago by calamity
Modified:
4 years, 3 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@disable_test
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD History] Use box-shadow to render card shadows everywhere. This CL changes the filter that was used to render the shadow on the history list into a box shadow to fix scrolling performance on various systems. It was also necessary to add a clipping div around the background so that the shadow wouldn't render over other items. BUG=641223 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/986a0334a792a32a5dac3d72c0edfbaceeeff0c7 Cr-Commit-Position: refs/heads/master@{#416807}

Patch Set 1 : #

Patch Set 2 : rebase and add clip #

Total comments: 2

Patch Set 3 : add comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -50 lines) Patch
M chrome/browser/resources/md_history/app.crisper.js View 1 5 chunks +16 lines, -15 lines 0 comments Download
M chrome/browser/resources/md_history/app.vulcanized.html View 1 2 6 chunks +30 lines, -16 lines 0 comments Download
M chrome/browser/resources/md_history/grouped_list.html View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/resources/md_history/history_item.html View 1 2 3 chunks +29 lines, -3 lines 0 comments Download
M chrome/browser/resources/md_history/history_list.html View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/md_history/shared_vars.html View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/resources/md_history/synced_device_card.html View 1 2 chunks +2 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 16 (7 generated)
calamity
4 years, 3 months ago (2016-08-26 05:58:47 UTC) #4
tsergeant
On 2016/08/26 05:58:47, calamity wrote: I'm seeing quite noticeable lines between items when I patch ...
4 years, 3 months ago (2016-08-28 23:20:31 UTC) #5
calamity
I think this may fix the lines. PTAL.
4 years, 3 months ago (2016-09-06 04:43:58 UTC) #6
tsergeant
This fixes everything for me but some veeeery faint lines at 110%. I'm happy enough ...
4 years, 3 months ago (2016-09-06 05:04:26 UTC) #7
calamity
https://codereview.chromium.org/2278383002/diff/40001/chrome/browser/resources/md_history/history_item.html File chrome/browser/resources/md_history/history_item.html (right): https://codereview.chromium.org/2278383002/diff/40001/chrome/browser/resources/md_history/history_item.html#newcode121 chrome/browser/resources/md_history/history_item.html:121: @apply(--shadow-elevation-2dp); On 2016/09/06 05:04:26, tsergeant wrote: > "Is it ...
4 years, 3 months ago (2016-09-06 06:01:02 UTC) #9
tsergeant
lgtm
4 years, 3 months ago (2016-09-06 07:59:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2278383002/60001
4 years, 3 months ago (2016-09-06 23:29:59 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 3 months ago (2016-09-07 00:56:19 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 00:58:10 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/986a0334a792a32a5dac3d72c0edfbaceeeff0c7
Cr-Commit-Position: refs/heads/master@{#416807}

Powered by Google App Engine
This is Rietveld 408576698