Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6923)

Unified Diff: chrome/browser/resources/md_history/app.js

Issue 2253083003: [MD History] Add shadow to toolbar on scroll. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@more_stats
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/md_history/app.html ('k') | chrome/browser/resources/md_history/app.crisper.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/md_history/app.js
diff --git a/chrome/browser/resources/md_history/app.js b/chrome/browser/resources/md_history/app.js
index 6c594ff496048e04a0a9415f277ffc98a5f71d91..c1de3c39eac53155f0d199d85059a5de812f9b0e 100644
--- a/chrome/browser/resources/md_history/app.js
+++ b/chrome/browser/resources/md_history/app.js
@@ -5,6 +5,8 @@
Polymer({
is: 'history-app',
+ behaviors: [Polymer.IronScrollTargetBehavior],
+
properties: {
showSidebarFooter: Boolean,
@@ -62,6 +64,12 @@ Polymer({
// 'otherDevicesInitialized'.
value: loadTimeData.getBoolean('isUserSignedIn'),
},
+
+ toolbarShadow_: {
+ type: Boolean,
+ reflectToAttribute: true,
+ notify: true,
+ }
},
observers: [
@@ -83,7 +91,7 @@ Polymer({
'delete-selected': 'deleteSelected',
'search-domain': 'searchDomain_',
'history-close-drawer': 'closeDrawer_',
- 'history-view-changed': 'recordHistoryPageView_',
+ 'history-view-changed': 'historyViewChanged_',
},
/** @override */
@@ -117,6 +125,11 @@ Polymer({
}
},
+ /** Overridden from IronScrollTargetBehavior */
+ _scrollHandler: function() {
+ this.toolbarShadow_ = this.scrollTarget.scrollTop != 0;
+ },
+
/** @private */
onMenuTap_: function() {
var drawer = this.$$('#drawer');
@@ -291,6 +304,17 @@ Polymer({
*/
selectedPageChanged_: function(selectedPage) {
this.set('routeData_.page', selectedPage);
+ this.historyViewChanged_();
+ },
+
+ /** @private */
+ historyViewChanged_: function() {
+ // This allows the synced-device-manager to render so that it can be set as
+ // the scroll target.
+ requestAnimationFrame(function() {
+ this.scrollTarget = this.$.content.selectedItem.getContentScrollTarget();
+ this._scrollHandler();
+ }.bind(this));
this.recordHistoryPageView_();
},
« no previous file with comments | « chrome/browser/resources/md_history/app.html ('k') | chrome/browser/resources/md_history/app.crisper.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698