Refactoring button field and its type (2nd try)

Refactoring button field and its type  (2nd try)

The original CL (crrev.com/2227563003) which is the same as
patchset 1 here got reverted due to memory problems and the fact
that enum sizes were not int and created gaps inside the
object memory space.

- Remove m_button field from PlatformMouseEvent as
    there was one in WebPointerProperties.
- Remove duplicate PlatformMouseEvent::MouseButton
    and WebScrollbarBehavior::Button enums and use
    WebPointerProperties::Button enum instead.
- Making WebPointerProperties::Button an enum class.

- Also cleanup related target for pointerevents. The related
    target for all pointerevents (similar to mouseevent)
    should be null except for boundary events. So
    relatedTarget can be removed from some of the functions
    as they don't send boundary events.

TBR=pdr@chromium.org, bokan@chromium.org, dtapuska@chromium.org, mustaq@chromium.org, pfeldman@chromium.org, sky@chromium.org, thestig@chromium.org

BUG=635670
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/656569e7720f728ee023447a270376ed17754dfc
Cr-Commit-Position: refs/heads/master@{#413168}

[Navid Zolghadr, 2016-08-18 14:52:41]

Description was changed from

==========
Fix new instances


Remove button field from PlatformMouseEvent

Remove button field and MouseButton enum
from PlatformMouseEvent.
Also cleanup related target for pointerevents.

move to enum class

t rebase -i master
fix compile issues for other platforms

Fix the rest of instances

fixing more

Fix mac/win errors

Better names/description

BUG=635670
==========

to

==========
Fix new instances


Remove button field from PlatformMouseEvent

Remove button field and MouseButton enum
from PlatformMouseEvent.
Also cleanup related target for pointerevents.

move to enum class

t rebase -i master
fix compile issues for other platforms

Fix the rest of instances

fixing more

Fix mac/win errors

Better names/description

BUG=635670
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Navid Zolghadr, 2016-08-18 14:54:41]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 14:54:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Navid Zolghadr, 2016-08-18 14:56:59]

The CQ bit was unchecked by nzolghadr@chromium.org

[Navid Zolghadr, 2016-08-18 14:58:11]

Description was changed from

==========
Fix new instances


Remove button field from PlatformMouseEvent

Remove button field and MouseButton enum
from PlatformMouseEvent.
Also cleanup related target for pointerevents.

move to enum class

t rebase -i master
fix compile issues for other platforms

Fix the rest of instances

fixing more

Fix mac/win errors

Better names/description

BUG=635670
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Refactoring button field and its type  (2nd try)

- Remove m_button field from PlatformMouseEvent as
    there was one in WebPointerProperties.
- Remove duplicate PlatformMouseEvent::MouseButton
    and WebScrollbarBehavior::Button enums and use
    WebPointerProperties::Button enum instead.
- Making WebPointerProperties::Button an enum class.

- Also cleanup related target for pointerevents. The related target for all
pointerevents (similar to mouseevent) should be null except for boundary events.
So relatedTarget can be removed from some of the functions as they don't send
boundary events.

BUG=635670
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Navid Zolghadr, 2016-08-18 18:52:27]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 18:52:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Navid Zolghadr, 2016-08-18 18:53:48]

The CQ bit was unchecked by nzolghadr@chromium.org

[Navid Zolghadr, 2016-08-18 20:37:28]

Description was changed from

==========
Refactoring button field and its type  (2nd try)

- Remove m_button field from PlatformMouseEvent as
    there was one in WebPointerProperties.
- Remove duplicate PlatformMouseEvent::MouseButton
    and WebScrollbarBehavior::Button enums and use
    WebPointerProperties::Button enum instead.
- Making WebPointerProperties::Button an enum class.

- Also cleanup related target for pointerevents. The related target for all
pointerevents (similar to mouseevent) should be null except for boundary events.
So relatedTarget can be removed from some of the functions as they don't send
boundary events.

BUG=635670
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Refactoring button field and its type  (2nd try)

- Remove m_button field from PlatformMouseEvent as
    there was one in WebPointerProperties.
- Remove duplicate PlatformMouseEvent::MouseButton
    and WebScrollbarBehavior::Button enums and use
    WebPointerProperties::Button enum instead.
- Making WebPointerProperties::Button an enum class.

- Also cleanup related target for pointerevents. The related target for all
pointerevents (similar to mouseevent) should be null except for boundary events.
So relatedTarget can be removed from some of the functions as they don't send
boundary events.

TBR=pdr@chromium.org, bokan@chromium.org, dtapuska@chromium.org,
mustaq@chromium.org, pfeldman@chromium.org, sky@chromium.org,
thestig@chromium.org 

BUG=635670
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Navid Zolghadr, 2016-08-18 20:37:28]

nzolghadr@chromium.org changed reviewers:
+ bokan@chromium.org, dtapuska@chromium.org, mustaq@chromium.org,
pdr@chromium.org, pfeldman@chromium.org, sky@chromium.org, thestig@chromium.org

[Navid Zolghadr, 2016-08-19 11:59:23]

The CQ bit was checked by nzolghadr@chromium.org

[commit-bot: I haz the power, 2016-08-19 11:59:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 12:06:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 12:06:52]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Navid Zolghadr, 2016-08-19 12:42:02]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 12:42:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Navid Zolghadr, 2016-08-19 13:43:53]

The CQ bit was unchecked by nzolghadr@chromium.org

[Navid Zolghadr, 2016-08-19 13:44:08]

The CQ bit was checked by nzolghadr@chromium.org

[commit-bot: I haz the power, 2016-08-19 13:44:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Navid Zolghadr, 2016-08-19 14:13:21]

The CQ bit was unchecked by nzolghadr@chromium.org

[Navid Zolghadr, 2016-08-19 14:14:17]

The CQ bit was checked by nzolghadr@chromium.org

[commit-bot: I haz the power, 2016-08-19 14:14:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mustaq, 2016-08-19 14:53:47]

LGTM. Please mention in the bug why the int8/int distinction matters here.

[Lei Zhang, 2016-08-19 16:37:35]

- Please reference the CL for the first try
- The CL description looks funny. Some of the
  bullet points are line wrapped.
  - but the last bullet point is not and it is very very very long......
- Is patch set 1 the previous try that got reverted?
- Please remind us who is reviewing what.

[commit-bot: I haz the power, 2016-08-19 16:53:20]

Description was changed from

==========
Refactoring button field and its type  (2nd try)

- Remove m_button field from PlatformMouseEvent as
    there was one in WebPointerProperties.
- Remove duplicate PlatformMouseEvent::MouseButton
    and WebScrollbarBehavior::Button enums and use
    WebPointerProperties::Button enum instead.
- Making WebPointerProperties::Button an enum class.

- Also cleanup related target for pointerevents. The related target for all
pointerevents (similar to mouseevent) should be null except for boundary events.
So relatedTarget can be removed from some of the functions as they don't send
boundary events.

TBR=pdr@chromium.org, bokan@chromium.org, dtapuska@chromium.org,
mustaq@chromium.org, pfeldman@chromium.org, sky@chromium.org,
thestig@chromium.org 

BUG=635670
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Refactoring button field and its type  (2nd try)

- Remove m_button field from PlatformMouseEvent as
    there was one in WebPointerProperties.
- Remove duplicate PlatformMouseEvent::MouseButton
    and WebScrollbarBehavior::Button enums and use
    WebPointerProperties::Button enum instead.
- Making WebPointerProperties::Button an enum class.

- Also cleanup related target for pointerevents. The related target for all
pointerevents (similar to mouseevent) should be null except for boundary events.
So relatedTarget can be removed from some of the functions as they don't send
boundary events.

TBR=pdr@chromium.org, bokan@chromium.org, dtapuska@chromium.org,
mustaq@chromium.org, pfeldman@chromium.org, sky@chromium.org,
thestig@chromium.org 

BUG=635670
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-08-19 16:53:24]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-19 16:56:15]

Description was changed from

==========
Refactoring button field and its type  (2nd try)

- Remove m_button field from PlatformMouseEvent as
    there was one in WebPointerProperties.
- Remove duplicate PlatformMouseEvent::MouseButton
    and WebScrollbarBehavior::Button enums and use
    WebPointerProperties::Button enum instead.
- Making WebPointerProperties::Button an enum class.

- Also cleanup related target for pointerevents. The related target for all
pointerevents (similar to mouseevent) should be null except for boundary events.
So relatedTarget can be removed from some of the functions as they don't send
boundary events.

TBR=pdr@chromium.org, bokan@chromium.org, dtapuska@chromium.org,
mustaq@chromium.org, pfeldman@chromium.org, sky@chromium.org,
thestig@chromium.org 

BUG=635670
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Refactoring button field and its type  (2nd try)

- Remove m_button field from PlatformMouseEvent as
    there was one in WebPointerProperties.
- Remove duplicate PlatformMouseEvent::MouseButton
    and WebScrollbarBehavior::Button enums and use
    WebPointerProperties::Button enum instead.
- Making WebPointerProperties::Button an enum class.

- Also cleanup related target for pointerevents. The related target for all
pointerevents (similar to mouseevent) should be null except for boundary events.
So relatedTarget can be removed from some of the functions as they don't send
boundary events.

TBR=pdr@chromium.org, bokan@chromium.org, dtapuska@chromium.org,
mustaq@chromium.org, pfeldman@chromium.org, sky@chromium.org,
thestig@chromium.org

BUG=635670
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/656569e7720f728ee023447a270376ed17754dfc
Cr-Commit-Position: refs/heads/master@{#413168}
==========

[commit-bot: I haz the power, 2016-08-19 16:56:18]

Patchset 3 (id:??) landed as
https://crrev.com/656569e7720f728ee023447a270376ed17754dfc
Cr-Commit-Position: refs/heads/master@{#413168}

[Navid Zolghadr, 2016-08-19 17:22:22]

Description was changed from

==========
Refactoring button field and its type  (2nd try)

- Remove m_button field from PlatformMouseEvent as
    there was one in WebPointerProperties.
- Remove duplicate PlatformMouseEvent::MouseButton
    and WebScrollbarBehavior::Button enums and use
    WebPointerProperties::Button enum instead.
- Making WebPointerProperties::Button an enum class.

- Also cleanup related target for pointerevents. The related target for all
pointerevents (similar to mouseevent) should be null except for boundary events.
So relatedTarget can be removed from some of the functions as they don't send
boundary events.

TBR=pdr@chromium.org, bokan@chromium.org, dtapuska@chromium.org,
mustaq@chromium.org, pfeldman@chromium.org, sky@chromium.org,
thestig@chromium.org

BUG=635670
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/656569e7720f728ee023447a270376ed17754dfc
Cr-Commit-Position: refs/heads/master@{#413168}
==========

to

==========
Refactoring button field and its type  (2nd try)

The original CL (crrev.com/2227563003) which is the same as patchset 0 got
reverted due to memory problems and the fact that enum sizes were not int and
created gaps inside the object memory space.

- Remove m_button field from PlatformMouseEvent as
    there was one in WebPointerProperties.
- Remove duplicate PlatformMouseEvent::MouseButton
    and WebScrollbarBehavior::Button enums and use
    WebPointerProperties::Button enum instead.
- Making WebPointerProperties::Button an enum class.

- Also cleanup related target for pointerevents. The related
    target for all pointerevents (similar to mouseevent)
    should be null except for boundary events. So
    relatedTarget can be removed from some of the functions
    as they don't send boundary events.

TBR=pdr@chromium.org, bokan@chromium.org, dtapuska@chromium.org,
mustaq@chromium.org, pfeldman@chromium.org, sky@chromium.org,
thestig@chromium.org

BUG=635670
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/656569e7720f728ee023447a270376ed17754dfc
Cr-Commit-Position: refs/heads/master@{#413168}
==========

[Navid Zolghadr, 2016-08-19 17:22:46]

Description was changed from

==========
Refactoring button field and its type  (2nd try)

The original CL (crrev.com/2227563003) which is the same as patchset 0 got
reverted due to memory problems and the fact that enum sizes were not int and
created gaps inside the object memory space.

- Remove m_button field from PlatformMouseEvent as
    there was one in WebPointerProperties.
- Remove duplicate PlatformMouseEvent::MouseButton
    and WebScrollbarBehavior::Button enums and use
    WebPointerProperties::Button enum instead.
- Making WebPointerProperties::Button an enum class.

- Also cleanup related target for pointerevents. The related
    target for all pointerevents (similar to mouseevent)
    should be null except for boundary events. So
    relatedTarget can be removed from some of the functions
    as they don't send boundary events.

TBR=pdr@chromium.org, bokan@chromium.org, dtapuska@chromium.org,
mustaq@chromium.org, pfeldman@chromium.org, sky@chromium.org,
thestig@chromium.org

BUG=635670
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/656569e7720f728ee023447a270376ed17754dfc
Cr-Commit-Position: refs/heads/master@{#413168}
==========

to

==========
Refactoring button field and its type  (2nd try)

The original CL (crrev.com/2227563003) which is the same as
patchset 0 got reverted due to memory problems and the fact
that enum sizes were not int and created gaps inside the
object memory space.

- Remove m_button field from PlatformMouseEvent as
    there was one in WebPointerProperties.
- Remove duplicate PlatformMouseEvent::MouseButton
    and WebScrollbarBehavior::Button enums and use
    WebPointerProperties::Button enum instead.
- Making WebPointerProperties::Button an enum class.

- Also cleanup related target for pointerevents. The related
    target for all pointerevents (similar to mouseevent)
    should be null except for boundary events. So
    relatedTarget can be removed from some of the functions
    as they don't send boundary events.

TBR=pdr@chromium.org, bokan@chromium.org, dtapuska@chromium.org,
mustaq@chromium.org, pfeldman@chromium.org, sky@chromium.org,
thestig@chromium.org

BUG=635670
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/656569e7720f728ee023447a270376ed17754dfc
Cr-Commit-Position: refs/heads/master@{#413168}
==========

[Navid Zolghadr, 2016-08-19 17:25:13]

Description was changed from

==========
Refactoring button field and its type  (2nd try)

The original CL (crrev.com/2227563003) which is the same as
patchset 0 got reverted due to memory problems and the fact
that enum sizes were not int and created gaps inside the
object memory space.

- Remove m_button field from PlatformMouseEvent as
    there was one in WebPointerProperties.
- Remove duplicate PlatformMouseEvent::MouseButton
    and WebScrollbarBehavior::Button enums and use
    WebPointerProperties::Button enum instead.
- Making WebPointerProperties::Button an enum class.

- Also cleanup related target for pointerevents. The related
    target for all pointerevents (similar to mouseevent)
    should be null except for boundary events. So
    relatedTarget can be removed from some of the functions
    as they don't send boundary events.

TBR=pdr@chromium.org, bokan@chromium.org, dtapuska@chromium.org,
mustaq@chromium.org, pfeldman@chromium.org, sky@chromium.org,
thestig@chromium.org

BUG=635670
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/656569e7720f728ee023447a270376ed17754dfc
Cr-Commit-Position: refs/heads/master@{#413168}
==========

to

==========
Refactoring button field and its type  (2nd try)

The original CL (crrev.com/2227563003) which is the same as
patchset 1 here got reverted due to memory problems and the fact
that enum sizes were not int and created gaps inside the
object memory space.

- Remove m_button field from PlatformMouseEvent as
    there was one in WebPointerProperties.
- Remove duplicate PlatformMouseEvent::MouseButton
    and WebScrollbarBehavior::Button enums and use
    WebPointerProperties::Button enum instead.
- Making WebPointerProperties::Button an enum class.

- Also cleanup related target for pointerevents. The related
    target for all pointerevents (similar to mouseevent)
    should be null except for boundary events. So
    relatedTarget can be removed from some of the functions
    as they don't send boundary events.

TBR=pdr@chromium.org, bokan@chromium.org, dtapuska@chromium.org,
mustaq@chromium.org, pfeldman@chromium.org, sky@chromium.org,
thestig@chromium.org

BUG=635670
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/656569e7720f728ee023447a270376ed17754dfc
Cr-Commit-Position: refs/heads/master@{#413168}
==========

[Navid Zolghadr, 2016-08-19 17:31:28]

On 2016/08/19 16:37:35, Lei Zhang wrote:
> - Please reference the CL for the first try
> - The CL description looks funny. Some of the
>   bullet points are line wrapped.
>   - but the last bullet point is not and it is very very very long......
> - Is patch set 1 the previous try that got reverted?
> - Please remind us who is reviewing what.

I added a ref to the original CL.
I just copy pasted the description from the original CL. I guess I had added
that last line in here and I didn't pay attention to the length.

The first patchset is the same as the original CL. Patchset 2 is the actual
change which I removed the size in WebPointerProperties.h + rebase. Patchset 3
is just a rebase.

For the files:

bokan@chromium.org: Please review changes in 
thirdparty/WebKit/Source/core/*


sky@chromium.org: Please review changes in 
mojo/*

thestig@chromium.org: Please review changes in 
components/printing/*
chrome/browser/*

pdr@chromium.org: Please review changes in 
*/platform/*

[Lei Zhang, 2016-08-19 17:46:53]

On 2016/08/19 17:31:28, Navid Zolghadr wrote:
> I added a ref to the original CL.
> I just copy pasted the description from the original CL. I guess I had added
> that last line in here and I didn't pay attention to the length.

Thanks, though the commit landed with the old description. Oh well.

> The first patchset is the same as the original CL. Patchset 2 is the actual
> change which I removed the size in WebPointerProperties.h + rebase. Patchset 3
> is just a rebase.

There may not be a good way to do it from the command line, but I usually use
the web interface to edit the description of patch set 1 to say "previous try"
or something to that effect, to make it clear what's going on.

Anyway, lgtm.

[Navid Zolghadr, 2016-08-19 17:50:25]

On 2016/08/19 17:46:53, Lei Zhang wrote:
> On 2016/08/19 17:31:28, Navid Zolghadr wrote:
> > I added a ref to the original CL.
> > I just copy pasted the description from the original CL. I guess I had added
> > that last line in here and I didn't pay attention to the length.
> 
> Thanks, though the commit landed with the old description. Oh well.
> 
> > The first patchset is the same as the original CL. Patchset 2 is the actual
> > change which I removed the size in WebPointerProperties.h + rebase. Patchset
3
> > is just a rebase.
> 
> There may not be a good way to do it from the command line, but I usually use
> the web interface to edit the description of patch set 1 to say "previous try"
> or something to that effect, to make it clear what's going on.

Sure. That's a great idea. I'll do that for my next CL that gets reverted.

> 
> Anyway, lgtm.