content/browser/renderer_host/input/web_input_event_builders_android.cc - Issue 2252423002: Refactoring button field and its type (2nd try)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/web_input_event_builders_android.cc

Issue 2252423002: Refactoring button field and its type (2nd try) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebasing Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/input/touch_emulator_unittest.cc ('k') | content/browser/renderer_host/input/web_input_event_builders_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/input/web_input_event_builders_android.cc

diff --git a/content/browser/renderer_host/input/web_input_event_builders_android.cc b/content/browser/renderer_host/input/web_input_event_builders_android.cc

index 45d54e001a9e7cf3e647957b407f28f79e07a98b..016665399a487bceb948b457ef39652e539189a8 100644

--- a/content/browser/renderer_host/input/web_input_event_builders_android.cc

+++ b/content/browser/renderer_host/input/web_input_event_builders_android.cc

@@ -137,7 +137,7 @@ WebMouseEvent WebMouseEventBuilder::Build(

if (type == WebInputEvent::MouseDown || type == WebInputEvent::MouseUp)

result.button = button;

else

- result.button = WebMouseEvent::ButtonNone;

+ result.button = WebMouseEvent::Button::NoButton;

return result;

}

@@ -156,7 +156,7 @@ WebMouseWheelEvent WebMouseWheelEventBuilder::Build(float ticks_x,

result.windowX = window_x;

result.windowY = window_y;

result.timeStampSeconds = time_sec;

- result.button = WebMouseEvent::ButtonNone;

+ result.button = WebMouseEvent::Button::NoButton;

result.hasPreciseScrollingDeltas = true;

result.deltaX = ticks_x * tick_multiplier;

result.deltaY = ticks_y * tick_multiplier;