third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp - Issue 2252423002: Refactoring button field and its type (2nd try)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp

Issue 2252423002: Refactoring button field and its type (2nd try) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebasing Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp

diff --git a/third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp b/third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp

index 2c5082245acfa0d9e8519aa39221ee589736184d..40baeeb07c8448ab3af006fe57b275ac6d5ae3d5 100644

--- a/third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp

+++ b/third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp

@@ -206,7 +206,7 @@ void SliderThumbElement::defaultEventHandler(Event* event)

}

MouseEvent* mouseEvent = toMouseEvent(event);

- bool isLeftButton = mouseEvent->button() == LeftButton;

+ bool isLeftButton = mouseEvent->button() == static_cast<short>(WebPointerProperties::Button::Left);

const AtomicString& eventType = event->type();

// We intentionally do not call event->setDefaultHandled() here because