Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Side by Side Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 2252423002: Refactoring button field and its type (2nd try) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebasing Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 265 matching lines...) Expand 10 before | Expand all | Expand 10 after
276 { 276 {
277 if (!inputEvent) 277 if (!inputEvent)
278 return; 278 return;
279 279
280 unsigned short buttonNumber = 0; 280 unsigned short buttonNumber = 0;
281 if (inputEvent->type == WebInputEvent::MouseUp) { 281 if (inputEvent->type == WebInputEvent::MouseUp) {
282 282
283 const WebMouseEvent* mouseEvent = static_cast<const WebMouseEvent*>(inpu tEvent); 283 const WebMouseEvent* mouseEvent = static_cast<const WebMouseEvent*>(inpu tEvent);
284 284
285 switch (mouseEvent->button) { 285 switch (mouseEvent->button) {
286 case WebMouseEvent::ButtonLeft: 286 case WebMouseEvent::Button::Left:
287 buttonNumber = 0; 287 buttonNumber = 0;
288 break; 288 break;
289 case WebMouseEvent::ButtonMiddle: 289 case WebMouseEvent::Button::Middle:
290 buttonNumber = 1; 290 buttonNumber = 1;
291 break; 291 break;
292 case WebMouseEvent::ButtonRight: 292 case WebMouseEvent::Button::Right:
293 buttonNumber = 2; 293 buttonNumber = 2;
294 break; 294 break;
295 default: 295 default:
296 return; 296 return;
297 } 297 }
298 } else if ((WebInputEvent::isKeyboardEventType(inputEvent->type) && static_c ast<const WebKeyboardEvent*>(inputEvent)->windowsKeyCode == VKEY_RETURN) || WebI nputEvent::isGestureEventType(inputEvent->type)) { 298 } else if ((WebInputEvent::isKeyboardEventType(inputEvent->type) && static_c ast<const WebKeyboardEvent*>(inputEvent)->windowsKeyCode == VKEY_RETURN) || WebI nputEvent::isGestureEventType(inputEvent->type)) {
299 // Keyboard and gesture events can simulate mouse events. 299 // Keyboard and gesture events can simulate mouse events.
300 buttonNumber = 0; 300 buttonNumber = 0;
301 } else { 301 } else {
302 return; 302 return;
(...skipping 791 matching lines...) Expand 10 before | Expand all | Expand 10 after
1094 { 1094 {
1095 return wrapUnique(m_webView->scheduler()->createFrameScheduler(blameContext) .release()); 1095 return wrapUnique(m_webView->scheduler()->createFrameScheduler(blameContext) .release());
1096 } 1096 }
1097 1097
1098 double ChromeClientImpl::lastFrameTimeMonotonic() const 1098 double ChromeClientImpl::lastFrameTimeMonotonic() const
1099 { 1099 {
1100 return m_webView->lastFrameTimeMonotonic(); 1100 return m_webView->lastFrameTimeMonotonic();
1101 } 1101 }
1102 1102
1103 } // namespace blink 1103 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/AssertMatchingEnums.cpp ('k') | third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698