Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Unified Diff: third_party/WebKit/public/platform/WebPointerProperties.h

Issue 2252423002: Refactoring button field and its type (2nd try) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebasing Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/WebPointerProperties.h
diff --git a/third_party/WebKit/public/platform/WebPointerProperties.h b/third_party/WebKit/public/platform/WebPointerProperties.h
index 72d6086845149f2c17a62dfc775838a096aa1db9..0c0e13e93e3e0ed129b53ac9af6d98c4af0f3ba3 100644
--- a/third_party/WebKit/public/platform/WebPointerProperties.h
+++ b/third_party/WebKit/public/platform/WebPointerProperties.h
@@ -5,6 +5,7 @@
#ifndef WebPointerProperties_h
#define WebPointerProperties_h
+#include <cstdint>
#include <limits>
namespace blink {
@@ -17,23 +18,23 @@ namespace blink {
class WebPointerProperties {
public:
WebPointerProperties()
- : button(ButtonNone)
- , id(0)
+ : id(0)
, force(std::numeric_limits<float>::quiet_NaN())
, tiltX(0)
, tiltY(0)
+ , button(Button::NoButton)
, pointerType(PointerType::Unknown)
{
}
- enum Button {
- ButtonNone = -1,
- ButtonLeft,
- ButtonMiddle,
- ButtonRight
+ enum class Button {
+ NoButton = -1,
+ Left,
+ Middle,
+ Right
};
- enum class PointerType : int {
+ enum class PointerType {
Unknown,
Mouse,
Pen,
@@ -41,8 +42,6 @@ public:
LastEntry = Touch // Must be the last entry in the list
};
- Button button;
-
int id;
// The valid range is [0,1], with NaN meaning pressure is not supported by
@@ -55,6 +54,7 @@ public:
int tiltX;
int tiltY;
+ Button button;
PointerType pointerType;
};
« no previous file with comments | « third_party/WebKit/Source/web/tests/WebViewTest.cpp ('k') | third_party/WebKit/public/platform/WebScrollbarBehavior.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698