Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2251613002: test-results: builders and builderstate: bug fixes, tests (Closed)

Created:
4 years, 4 months ago by nishanths
Modified:
4 years, 4 months ago
Reviewers:
Vadim Sh., estaab, martiniss
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@cl-ing_upload
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

test-results: builders and builderstate: bug fixes, tests - Prefix vs. Contains (bug fix) - Do not include Master if builders list is empty (bug fix) - Add tests for cleanTestType - Rename handlers to be lowercase (consistent) BUG= Committed: https://chromium.googlesource.com/infra/infra/+/aeacf7b70f70f6b1e281ccca72d6df0c4fbea7c0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -10 lines) Patch
M go/src/infra/appengine/test-results/frontend/builders.go View 8 chunks +11 lines, -4 lines 0 comments Download
M go/src/infra/appengine/test-results/frontend/builders_test.go View 1 chunk +24 lines, -0 lines 0 comments Download
M go/src/infra/appengine/test-results/frontend/builderstate.go View 2 chunks +4 lines, -4 lines 0 comments Download
M go/src/infra/appengine/test-results/frontend/builderstate_test.go View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (3 generated)
nishanths
4 years, 4 months ago (2016-08-16 05:02:46 UTC) #2
Vadim Sh.
lgtm
4 years, 4 months ago (2016-08-16 18:27:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2251613002/1
4 years, 4 months ago (2016-08-16 18:28:04 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 18:41:54 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/aeacf7b70f70f6b1e281ccca72d6d...

Powered by Google App Engine
This is Rietveld 408576698