test-results: builders and builderstate: bug fixes, tests

go/src/infra/appengine/test-results/frontend/builderstate_test.go

 package frontend
 
 import (
         "errors"
         "io/ioutil"
         "net/http"
         "net/http/httptest"
         "testing"
 
         "golang.org/x/net/context"
 
         "github.com/luci/gae/impl/memory"
         "github.com/luci/gae/service/memcache"
         "github.com/luci/luci-go/server/router"
         . "github.com/smartystreets/goconvey/convey"
 
         "infra/appengine/test-results/builderstate"
 )
 
 func TestBuilderState(t *testing.T) {
         t.Parallel()
 
         testCtx := memory.Use(context.Background())
         WithTestingContext := func(c *router.Context, next router.Handler) {
                 c.Context = testCtx
                 next(c)
         }
         r := router.New()
         mw := router.NewMiddlewareChain(WithTestingContext)
-        r.GET("/builderstate", mw, GetBuilderState)
-        r.GET("/updatebuilderstate", mw, UpdateBuilderState)
+        r.GET("/builderstate", mw, getBuilderStateHandler)
+        r.GET("/updatebuilderstate", mw, updateBuilderStateHandler)
 
         srv := httptest.NewServer(r)
         client := &http.Client{}
 
         Convey("BuilderState", t, func() {
                 bsJSON := []byte(`{"masters":[]}`)
                 refreshed := false
 
                 Convey("GET /builderstate", func() {
                         Convey("cache miss, refresh fails: returns HTTP status 500", func() {
@@ skipping 71 matching lines @@
                                 So(resp.StatusCode, ShouldEqual, http.StatusOK)
                                 So(refreshed, ShouldBeTrue)
                                 data, err := ioutil.ReadAll(resp.Body)
                                 defer resp.Body.Close()
                                 So(err, ShouldBeNil)
                                 So(string(data), ShouldResemble, "OK")
                         })
                 })
         })
 }