Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: go/src/infra/appengine/test-results/frontend/builders_test.go

Issue 2251613002: test-results: builders and builderstate: bug fixes, tests (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@cl-ing_upload
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: go/src/infra/appengine/test-results/frontend/builders_test.go
diff --git a/go/src/infra/appengine/test-results/frontend/builders_test.go b/go/src/infra/appengine/test-results/frontend/builders_test.go
index 1cc0187568c769d1783f86ed9102a98ba9874fc3..0251522c5ae0afa7eb8bbe040593d37648f17016 100644
--- a/go/src/infra/appengine/test-results/frontend/builders_test.go
+++ b/go/src/infra/appengine/test-results/frontend/builders_test.go
@@ -11,7 +11,31 @@ import (
. "github.com/smartystreets/goconvey/convey"
)
+func TestCleanTestType(t *testing.T) {
+ t.Parallel()
+
+ Convey("cleanTestType", t, func() {
+ type testCase struct {
+ input, output string
+ }
+ testCases := []testCase{
+ {"base_unittests", "base_unittests"},
+ {"base_unittests on Windows XP", "base_unittests"},
+ {"base_unittests on Windows XP (with patch)", "base_unittests (with patch)"},
+ {"base_unittests on ATI GPU on Windows (with patch) on Windows", "base_unittests (with patch)"},
+ {"base_unittests (ATI GPU) on Windows (with patch) on Windows", "base_unittests (with patch)"},
+ {"base_unittests on ATI GPU on Windows (without patch) on Windows", "base_unittests"},
+ {"Instrumentation test content_shell_test_apk (with patch)", "content_shell_test_apk (with patch)"},
+ }
+ for _, tc := range testCases {
+ So(cleanTestType(tc.input), ShouldEqual, tc.output)
+ }
+ })
+}
+
func TestBuilders(t *testing.T) {
+ t.Parallel()
+
Convey("builders", t, func() {
Convey("getBuilderData", func() {
Convey("normal", func() {
« no previous file with comments | « go/src/infra/appengine/test-results/frontend/builders.go ('k') | go/src/infra/appengine/test-results/frontend/builderstate.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698