test-results: package frontend: add upload handler

test-results: package frontend: add upload handler

BUG=

Committed: https://chromium.googlesource.com/infra/infra/+/60c56ff5bab1adce477d420c79a5d3abe8807c2f

[nishanths, 2016-08-12 14:57:39]

nishanths@google.com changed reviewers:
+ estaab@chromium.org, martiniss@chromium.org, vadimsh@chromium.org

[nishanths, 2016-08-12 14:57:40]

PTAL. This adds the upload handler and a test. Will add more tests soon!

[estaab, 2016-08-12 15:29:07]

lgtm

https://codereview.chromium.org/2240473004/diff/1/go/src/infra/appengine/test...
File go/src/infra/appengine/test-results/frontend/upload.go (right):

https://codereview.chromium.org/2240473004/diff/1/go/src/infra/appengine/test...
go/src/infra/appengine/test-results/frontend/upload.go:47: Master, DeprMaster,
Builder, TestType string
What's DeprMaster? perhaps document since it's not obvious

https://codereview.chromium.org/2240473004/diff/1/go/src/infra/appengine/test...
go/src/infra/appengine/test-results/frontend/upload.go:69: func
cleanTestType(test string) string {
isn't this also in builders.go? Would there be a way to not duplicate it? If
not, can you reference the other file and mention we need to keep them in sync?

https://codereview.chromium.org/2240473004/diff/1/go/src/infra/appengine/test...
go/src/infra/appengine/test-results/frontend/upload.go:326: wg.Add(1)
It seems a little messy to reuse the WaitGroup from the outer scope since the
reader has to double check what state it's in to understand this function. Maybe
just make a new one?

[nishanths, 2016-08-16 05:16:29]

Addressed comments. :)

https://codereview.chromium.org/2240473004/diff/1/go/src/infra/appengine/test...
File go/src/infra/appengine/test-results/frontend/upload.go (right):

https://codereview.chromium.org/2240473004/diff/1/go/src/infra/appengine/test...
go/src/infra/appengine/test-results/frontend/upload.go:47: Master, DeprMaster,
Builder, TestType string
On 2016/08/12 15:29:07, estaab wrote:
> What's DeprMaster? perhaps document since it's not obvious

Done.

https://codereview.chromium.org/2240473004/diff/1/go/src/infra/appengine/test...
go/src/infra/appengine/test-results/frontend/upload.go:69: func
cleanTestType(test string) string {
On 2016/08/12 15:29:07, estaab wrote:
> isn't this also in builders.go? Would there be a way to not duplicate it? If
> not, can you reference the other file and mention we need to keep them in
sync?

Done. Removed from here. Both instances are in the same package.
(duplicated it here because I was unsure which CL would land first)

https://codereview.chromium.org/2240473004/diff/1/go/src/infra/appengine/test...
go/src/infra/appengine/test-results/frontend/upload.go:326: wg.Add(1)
On 2016/08/12 15:29:07, estaab wrote:
> It seems a little messy to reuse the WaitGroup from the outer scope since the
> reader has to double check what state it's in to understand this function.
Maybe
> just make a new one?

Done.

[nishanths, 2016-08-16 16:54:34]

The CQ bit was checked by nishanths@google.com

[nishanths, 2016-08-16 16:54:34]

The patchset sent to the CQ was uploaded after l-g-t-m from estaab@chromium.org
Link to the patchset: https://codereview.chromium.org/2240473004/#ps20001
(title: "Address estaab@ comments, set dependent CL")

[commit-bot: I haz the power, 2016-08-16 16:54:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 17:08:04]

Description was changed from

==========
test-results: package frontend: add upload handler

BUG=
==========

to

==========
test-results: package frontend: add upload handler

BUG=

Committed:
https://chromium.googlesource.com/infra/infra/+/60c56ff5bab1adce477d420c79a5d...
==========

[commit-bot: I haz the power, 2016-08-16 17:08:04]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/60c56ff5bab1adce477d420c79a5d...