Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: go/src/infra/appengine/test-results/frontend/builderstate.go

Issue 2251613002: test-results: builders and builderstate: bug fixes, tests (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@cl-ing_upload
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: go/src/infra/appengine/test-results/frontend/builderstate.go
diff --git a/go/src/infra/appengine/test-results/frontend/builderstate.go b/go/src/infra/appengine/test-results/frontend/builderstate.go
index c4c5dc6a42c67b2b2390ef386830d1ac4dfcbb1a..6cd2934b2f8d339673e631de85c5a96ce79eae7c 100644
--- a/go/src/infra/appengine/test-results/frontend/builderstate.go
+++ b/go/src/infra/appengine/test-results/frontend/builderstate.go
@@ -18,9 +18,9 @@ import (
// It is global to allow mocking in tests.
var refreshFunc = builderstate.RefreshCache
-// GetBuilderState gets data from the builder state memcache
+// getBuilderStateHandler gets data from the builder state memcache
// and serves it as JSON.
-func GetBuilderState(ctx *router.Context) {
+func getBuilderStateHandler(ctx *router.Context) {
c, w := ctx.Context, ctx.Writer
item, err := memcache.Get(c).Get(builderstate.MemcacheKey)
@@ -50,9 +50,9 @@ func GetBuilderState(ctx *router.Context) {
logging.Debugf(c, "took %s to write response", time.Since(start))
}
-// UpdateBuilderState refreshes data in the builder state
+// updateBuilderStateHandler refreshes data in the builder state
// memcache.
-func UpdateBuilderState(ctx *router.Context) {
+func updateBuilderStateHandler(ctx *router.Context) {
c, w := ctx.Context, ctx.Writer
_, err := refreshFunc(c)

Powered by Google App Engine
This is Rietveld 408576698