Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2245403002: Don't reuse the minidump descriptor for the crash signal pipe. (Closed)

Created:
4 years, 4 months ago by Tobias Sargeant
Modified:
4 years, 4 months ago
Reviewers:
Robert Sesek, Torne
CC:
chromium-reviews, jam, darin-cc_chromium.org, android-webview-reviews_chromium.org, sadrul, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't reuse the minidump descriptor for the crash signal pipe. This gets in the way of generating minidumps in WebView, and also interacts badly with the DumpWithoutCrashingToFd implementation. BUG=633979 Committed: https://crrev.com/cc607cc759e50fbb2dc2d0395952b6a02bfbe540 Cr-Commit-Position: refs/heads/master@{#412493}

Patch Set 1 #

Patch Set 2 : initialize crash_signal_fd_ #

Patch Set 3 : amend comment; default implementation should return an invalid fd #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M android_webview/crash_reporter/aw_microdump_crash_reporter.cc View 1 3 chunks +4 lines, -2 lines 0 comments Download
M components/crash/content/app/breakpad_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/crash/content/app/crash_reporter_client.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M components/crash/content/app/crash_reporter_client.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Tobias Sargeant
4 years, 4 months ago (2016-08-16 11:49:06 UTC) #6
Torne
lgtm
4 years, 4 months ago (2016-08-16 11:50:47 UTC) #7
Robert Sesek
lgtm
4 years, 4 months ago (2016-08-16 19:26:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2245403002/40001
4 years, 4 months ago (2016-08-17 09:37:28 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-17 10:46:49 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 10:50:14 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cc607cc759e50fbb2dc2d0395952b6a02bfbe540
Cr-Commit-Position: refs/heads/master@{#412493}

Powered by Google App Engine
This is Rietveld 408576698