Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: components/crash/content/app/crash_reporter_client.cc

Issue 2245403002: Don't reuse the minidump descriptor for the crash signal pipe. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: amend comment; default implementation should return an invalid fd Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/crash/content/app/crash_reporter_client.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/crash/content/app/crash_reporter_client.h" 5 #include "components/crash/content/app/crash_reporter_client.h"
6 6
7 #include "build/build_config.h" 7 #include "build/build_config.h"
8 8
9 // On Windows don't use FilePath and logging.h. 9 // On Windows don't use FilePath and logging.h.
10 // http://crbug.com/604923 10 // http://crbug.com/604923
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 bool CrashReporterClient::ReportingIsEnforcedByPolicy(bool* breakpad_enabled) { 126 bool CrashReporterClient::ReportingIsEnforcedByPolicy(bool* breakpad_enabled) {
127 return false; 127 return false;
128 } 128 }
129 #endif 129 #endif
130 130
131 #if defined(OS_ANDROID) 131 #if defined(OS_ANDROID)
132 int CrashReporterClient::GetAndroidMinidumpDescriptor() { 132 int CrashReporterClient::GetAndroidMinidumpDescriptor() {
133 return 0; 133 return 0;
134 } 134 }
135 135
136 int CrashReporterClient::GetAndroidCrashSignalFD() {
137 return -1;
138 }
139
136 bool CrashReporterClient::ShouldEnableBreakpadMicrodumps() { 140 bool CrashReporterClient::ShouldEnableBreakpadMicrodumps() {
137 // Always enable microdumps on Android when stripping unwind tables. Rationale: 141 // Always enable microdumps on Android when stripping unwind tables. Rationale:
138 // when unwind tables are stripped out (to save binary size) the stack traces 142 // when unwind tables are stripped out (to save binary size) the stack traces
139 // produced locally in the case of a crash / CHECK are meaningless. In order to 143 // produced locally in the case of a crash / CHECK are meaningless. In order to
140 // provide meaningful development diagnostics (and keep the binary size savings) 144 // provide meaningful development diagnostics (and keep the binary size savings)
141 // on Android we attach a secondary crash handler which serializes a reduced 145 // on Android we attach a secondary crash handler which serializes a reduced
142 // form of logcat on the console. 146 // form of logcat on the console.
143 #if defined(NO_UNWIND_TABLES) 147 #if defined(NO_UNWIND_TABLES)
144 return true; 148 return true;
145 #else 149 #else
146 return false; 150 return false;
147 #endif 151 #endif
148 } 152 }
149 #endif 153 #endif
150 154
151 bool CrashReporterClient::EnableBreakpadForProcess( 155 bool CrashReporterClient::EnableBreakpadForProcess(
152 const std::string& process_type) { 156 const std::string& process_type) {
153 return false; 157 return false;
154 } 158 }
155 159
156 } // namespace crash_reporter 160 } // namespace crash_reporter
OLDNEW
« no previous file with comments | « components/crash/content/app/crash_reporter_client.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698