components/crash/content/app/breakpad_linux.cc - Issue 2245403002: Don't reuse the minidump descriptor for the crash signal pipe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/crash/content/app/breakpad_linux.cc

Issue 2245403002: Don't reuse the minidump descriptor for the crash signal pipe. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: amend comment; default implementation should return an invalid fd Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/crash_reporter/aw_microdump_crash_reporter.cc ('k') | components/crash/content/app/crash_reporter_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/crash/content/app/breakpad_linux.cc

diff --git a/components/crash/content/app/breakpad_linux.cc b/components/crash/content/app/breakpad_linux.cc

index 0c89d49eb0dee7ca92bc7c684e5ee2c26ce2cb43..9ebc33f4f01ce975604b921303e43c3af59a04cb 100644

--- a/components/crash/content/app/breakpad_linux.cc

+++ b/components/crash/content/app/breakpad_linux.cc

@@ -932,7 +932,7 @@ void MicrodumpInfo::Initialize(const std::string& process_type,

&GenerateMinidumpOnDemandForAndroid);

} else if (!process_type.empty()) {

g_signal_code_pipe_fd =

- GetCrashReporterClient()->GetAndroidMinidumpDescriptor();

+ GetCrashReporterClient()->GetAndroidCrashSignalFD();

if (g_signal_code_pipe_fd != -1)

g_microdump->set_crash_handler(WriteSignalCodeToPipe);

}