Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Side by Side Diff: components/crash/content/app/crash_reporter_client.h

Issue 2245403002: Don't reuse the minidump descriptor for the crash signal pipe. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: amend comment; default implementation should return an invalid fd Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_CRASH_CONTENT_APP_CRASH_REPORTER_CLIENT_H_ 5 #ifndef COMPONENTS_CRASH_CONTENT_APP_CRASH_REPORTER_CLIENT_H_
6 #define COMPONENTS_CRASH_CONTENT_APP_CRASH_REPORTER_CLIENT_H_ 6 #define COMPONENTS_CRASH_CONTENT_APP_CRASH_REPORTER_CLIENT_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <string> 10 #include <string>
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 #if defined(OS_WIN) || defined(OS_MACOSX) 141 #if defined(OS_WIN) || defined(OS_MACOSX)
142 // Returns true if crash reporting is enforced via management policies. In 142 // Returns true if crash reporting is enforced via management policies. In
143 // that case, |breakpad_enabled| is set to the value enforced by policies. 143 // that case, |breakpad_enabled| is set to the value enforced by policies.
144 virtual bool ReportingIsEnforcedByPolicy(bool* breakpad_enabled); 144 virtual bool ReportingIsEnforcedByPolicy(bool* breakpad_enabled);
145 #endif 145 #endif
146 146
147 #if defined(OS_ANDROID) 147 #if defined(OS_ANDROID)
148 // Returns the descriptor key of the android minidump global descriptor. 148 // Returns the descriptor key of the android minidump global descriptor.
149 virtual int GetAndroidMinidumpDescriptor(); 149 virtual int GetAndroidMinidumpDescriptor();
150 150
151 // Returns the file descriptor of the pipe used to inform apps of
152 // webview renderer crashes.
153 virtual int GetAndroidCrashSignalFD();
154
151 // Returns true if breakpad microdumps should be enabled. This orthogonal to 155 // Returns true if breakpad microdumps should be enabled. This orthogonal to
152 // the standard minidump uploader (which depends on the user consent). 156 // the standard minidump uploader (which depends on the user consent).
153 virtual bool ShouldEnableBreakpadMicrodumps(); 157 virtual bool ShouldEnableBreakpadMicrodumps();
154 #endif 158 #endif
155 159
156 // Returns true if breakpad should run in the given process type. 160 // Returns true if breakpad should run in the given process type.
157 virtual bool EnableBreakpadForProcess(const std::string& process_type); 161 virtual bool EnableBreakpadForProcess(const std::string& process_type);
158 }; 162 };
159 163
160 } // namespace crash_reporter 164 } // namespace crash_reporter
161 165
162 #endif // COMPONENTS_CRASH_CONTENT_APP_CRASH_REPORTER_CLIENT_H_ 166 #endif // COMPONENTS_CRASH_CONTENT_APP_CRASH_REPORTER_CLIENT_H_
OLDNEW
« no previous file with comments | « components/crash/content/app/breakpad_linux.cc ('k') | components/crash/content/app/crash_reporter_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698