components/crash/content/app/crash_reporter_client.cc - Issue 2245403002: Don't reuse the minidump descriptor for the crash signal pipe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/crash/content/app/crash_reporter_client.cc

Issue 2245403002: Don't reuse the minidump descriptor for the crash signal pipe. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: amend comment; default implementation should return an invalid fd Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/crash/content/app/crash_reporter_client.cc

diff --git a/components/crash/content/app/crash_reporter_client.cc b/components/crash/content/app/crash_reporter_client.cc

index 22b95712995b6f31b1d2b132b3370317f5173f15..1a526f011b5451c9ae8c70d8385e586c8bfa7c63 100644

--- a/components/crash/content/app/crash_reporter_client.cc

+++ b/components/crash/content/app/crash_reporter_client.cc

@@ -133,6 +133,10 @@ int CrashReporterClient::GetAndroidMinidumpDescriptor() {

return 0;

}

+int CrashReporterClient::GetAndroidCrashSignalFD() {

+ return -1;

bool CrashReporterClient::ShouldEnableBreakpadMicrodumps() {

// Always enable microdumps on Android when stripping unwind tables. Rationale:

// when unwind tables are stripped out (to save binary size) the stack traces

« no previous file with comments | « components/crash/content/app/crash_reporter_client.h ('k') | no next file » | no next file with comments »