Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2245013003: Remove "list item" from Android NTP class names. (Closed)

Created:
4 years, 4 months ago by Bernhard Bauer
Modified:
4 years, 4 months ago
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove "list item" from Android NTP class names. This is in preparation for more refactorings that will get rid of having an explicit list of NTP items. BUG=616090 Committed: https://crrev.com/3323db9ee62d0bc21278d904823413a7f2cff3a6 Cr-Commit-Position: refs/heads/master@{#412087}

Patch Set 1 #

Patch Set 2 : x #

Patch Set 3 : x #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -919 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
A + chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/AboveTheFoldItem.java View 1 1 chunk +3 lines, -3 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/AboveTheFoldListItem.java View 1 chunk +0 lines, -21 lines 0 comments Download
A + chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java View 1 2 chunks +6 lines, -6 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionListItem.java View 1 chunk +0 lines, -64 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ItemGroup.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java View 10 chunks +27 lines, -27 lines 0 comments Download
A + chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageItem.java View 1 2 chunks +6 lines, -6 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageListItem.java View 1 chunk +0 lines, -75 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageViewHolder.java View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
A + chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ProgressItem.java View 1 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ProgressListItem.java View 1 chunk +0 lines, -28 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ProgressViewHolder.java View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SingleItemGroup.java View 1 chunk +4 lines, -4 lines 0 comments Download
A + chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SpacingItem.java View 1 2 chunks +5 lines, -5 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SpacingListItem.java View 1 chunk +0 lines, -38 lines 0 comments Download
A + chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusItem.java View 1 7 chunks +9 lines, -9 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusListItem.java View 1 chunk +0 lines, -162 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java View 5 chunks +17 lines, -17 lines 0 comments Download
A + chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SectionHeader.java View 1 2 chunks +4 lines, -20 lines 0 comments Download
A + chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SectionHeaderViewHolder.java View 1 3 chunks +7 lines, -7 lines 0 comments Download
A + chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java View 1 4 chunks +6 lines, -6 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleListItem.java View 1 chunk +0 lines, -169 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java View 5 chunks +7 lines, -7 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderListItem.java View 1 chunk +0 lines, -55 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java View 1 chunk +0 lines, -92 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsSource.java View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/android/java_sources.gni View 1 chunk +15 lines, -15 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java View 15 chunks +43 lines, -43 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
Bernhard Bauer
Please review. Thanks!
4 years, 4 months ago (2016-08-15 21:17:32 UTC) #10
PEConn
LGTM - thanks for this, it'll make everything more readable!.
4 years, 4 months ago (2016-08-15 22:56:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2245013003/40001
4 years, 4 months ago (2016-08-15 23:10:41 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-15 23:14:54 UTC) #16
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/3323db9ee62d0bc21278d904823413a7f2cff3a6 Cr-Commit-Position: refs/heads/master@{#412087}
4 years, 4 months ago (2016-08-15 23:16:38 UTC) #18
Michael van Ouwerkerk
lgtm I would have preferred to keep 'Item' in Header and Article though, to distinguish ...
4 years, 4 months ago (2016-08-16 09:20:51 UTC) #19
Bernhard Bauer
4 years, 4 months ago (2016-08-17 20:47:05 UTC) #20
Message was sent while issue was closed.
On 2016/08/16 09:20:51, Michael van Ouwerkerk wrote:
> lgtm
> 
> I would have preferred to keep 'Item' in Header and Article though, to
> distinguish them more clearly from the View and ViewHolder types.

What I was trying to do was actually to go the other direction and remove as
much suffix as possible, but for other things (StatusItem, AboveTheFoldItem)
leaving the Item out wouldn't really have worked :)

Powered by Google App Engine
This is Rietveld 408576698