Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8762)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusListItem.java

Issue 2245013003: Remove "list item" from Android NTP class names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: x Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusListItem.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusListItem.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusListItem.java
deleted file mode 100644
index 74921e3db3f8c619db19543050ce54d45f214f6c..0000000000000000000000000000000000000000
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusListItem.java
+++ /dev/null
@@ -1,162 +0,0 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-package org.chromium.chrome.browser.ntp.cards;
-
-import android.content.Context;
-import android.view.View;
-import android.view.View.OnClickListener;
-import android.widget.Button;
-import android.widget.TextView;
-
-import org.chromium.base.Log;
-import org.chromium.chrome.R;
-import org.chromium.chrome.browser.ntp.UiConfig;
-import org.chromium.chrome.browser.ntp.snippets.CategoryStatus;
-import org.chromium.chrome.browser.ntp.snippets.CategoryStatus.CategoryStatusEnum;
-import org.chromium.chrome.browser.signin.AccountSigninActivity;
-import org.chromium.chrome.browser.signin.SigninAccessPoint;
-
-/**
- * Card that is shown when the user needs to be made aware of some information about their
- * configuration about the NTP suggestions: there is no more available suggested content, sync
- * should be enabled, etc.
- */
-public abstract class StatusListItem implements NewTabPageListItem {
- /**
- * ViewHolder for an item of type {@link #VIEW_TYPE_STATUS}.
- */
- public static class ViewHolder extends CardViewHolder {
- private final TextView mTitleView;
- private final TextView mBodyView;
- private final Button mActionView;
-
- public ViewHolder(NewTabPageRecyclerView parent, UiConfig config) {
- super(R.layout.new_tab_page_status_card, parent, config);
- mTitleView = (TextView) itemView.findViewById(R.id.status_title);
- mBodyView = (TextView) itemView.findViewById(R.id.status_body);
- mActionView = (Button) itemView.findViewById(R.id.status_action_button);
- }
-
- @Override
- public void onBindViewHolder(NewTabPageListItem item) {
- assert item instanceof StatusListItem;
- super.onBindViewHolder(item);
-
- final StatusListItem listItem = (StatusListItem) item;
- mTitleView.setText(listItem.mHeaderStringId);
- mBodyView.setText(listItem.mDescriptionStringId);
-
- if (listItem.hasAction()) {
- mActionView.setText(listItem.mActionStringId);
- mActionView.setOnClickListener(new OnClickListener() {
-
- @Override
- public void onClick(View v) {
- listItem.performAction(v.getContext());
- }
- });
- mActionView.setVisibility(View.VISIBLE);
- } else {
- mActionView.setVisibility(View.GONE);
- }
- }
- }
-
- private static class NoSnippets extends StatusListItem {
- private final NewTabPageAdapter mNewTabPageAdapter;
-
- public NoSnippets(NewTabPageAdapter adapter) {
- super(R.string.ntp_status_card_title_empty,
- R.string.ntp_status_card_body_empty,
- R.string.reload);
- mNewTabPageAdapter = adapter;
- Log.d(TAG, "Registering card for status: No Snippets");
- }
-
- @Override
- protected void performAction(Context context) {
- mNewTabPageAdapter.reloadSnippets();
- }
- }
-
- private static class SignedOut extends StatusListItem {
- public SignedOut() {
- super(R.string.snippets_disabled_generic_prompt,
- R.string.snippets_disabled_signed_out_instructions,
- R.string.sign_in_button);
- Log.d(TAG, "Registering card for status: User Signed out");
- }
-
- @Override
- protected void performAction(Context context) {
- AccountSigninActivity.startIfAllowed(context, SigninAccessPoint.NTP_LINK);
- }
- }
-
- private static final String TAG = "NtpCards";
-
- private final int mHeaderStringId;
- private final int mDescriptionStringId;
- private final int mActionStringId;
-
- public static StatusListItem create(@CategoryStatusEnum int categoryStatus,
- NewTabPageAdapter adapter) {
- switch (categoryStatus) {
- // TODO(dgn): AVAILABLE_LOADING and INITIALIZING should show a progress indicator.
- case CategoryStatus.AVAILABLE:
- case CategoryStatus.AVAILABLE_LOADING:
- case CategoryStatus.INITIALIZING:
- return new NoSnippets(adapter);
-
- case CategoryStatus.SIGNED_OUT:
- return new SignedOut();
-
- case CategoryStatus.ALL_SUGGESTIONS_EXPLICITLY_DISABLED:
- Log.wtf(TAG, "Attempted to create a status card while the feature should be off.");
- return null;
-
- case CategoryStatus.CATEGORY_EXPLICITLY_DISABLED:
- // In this case, the entire section should have been cleared off the UI.
- Log.wtf(TAG, "Attempted to create a status card for content suggestions "
- + " when the category status is CATEGORY_EXPLICITLY_DISABLED.");
- return null;
-
- case CategoryStatus.NOT_PROVIDED:
- // In this case, the UI should remain as it is and also keep the previous category
- // status, so the NOT_PROVIDED should never reach here.
- Log.wtf(TAG, "Attempted to create a status card for content suggestions "
- + " when the category is NOT_PROVIDED.");
- return null;
-
- case CategoryStatus.LOADING_ERROR:
- // In this case, the entire section should have been cleared off the UI.
- Log.wtf(TAG, "Attempted to create a status card for content suggestions "
- + " when the category is LOADING_ERROR.");
- return null;
-
- default:
- Log.wtf(TAG, "Attempted to create a status card for an unknown value: %d",
- categoryStatus);
- return null;
- }
- }
-
- private StatusListItem(int headerStringId, int descriptionStringId, int actionStringId) {
- mHeaderStringId = headerStringId;
- mDescriptionStringId = descriptionStringId;
- mActionStringId = actionStringId;
- }
-
- protected abstract void performAction(Context context);
-
- protected boolean hasAction() {
- return true;
- }
-
- @Override
- public int getType() {
- return NewTabPageListItem.VIEW_TYPE_STATUS;
- }
-}

Powered by Google App Engine
This is Rietveld 408576698