chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java - Issue 2245013003: Remove "list item" from Android NTP class names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java

Issue 2245013003: Remove "list item" from Android NTP class names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: x Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionListItem.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ItemGroup.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java

index 44dbcdc2cd6df0cc0ebe67dc7f2d25868fa280cf..d1c6bcad99660763cde1d1a3b300539032a5e4f6 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java

@@ -39,7 +39,7 @@ import org.chromium.chrome.browser.util.MathUtils;

* - Cards will get some lateral margins when the viewport is sufficiently wide.

* (see {@link UiConfig#DISPLAY_STYLE_WIDE})

- * Note: If a subclass overrides {@link #onBindViewHolder(NewTabPageListItem)}, it should call the

+ * Note: If a subclass overrides {@link #onBindViewHolder(NewTabPageItem)}, it should call the

* parent implementation to reset the private state when a card is recycled.

public class CardViewHolder extends NewTabPageViewHolder {

@@ -125,7 +125,7 @@ public class CardViewHolder extends NewTabPageViewHolder {

* @param item The NewTabPageListItem object that holds the data for this ViewHolder

@Override

- public void onBindViewHolder(NewTabPageListItem item) {

+ public void onBindViewHolder(NewTabPageItem item) {

// Reset the peek status to avoid recycled view holders to be peeking at the wrong moment.

setPeekingPercentage(0f);