Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1639)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

Issue 2245013003: Remove "list item" from Android NTP class names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: x Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
index 7acd9c309a70662434272df9e5e252b8a90bbe64..fcac4dd151759cfc2ec24800ad612472662dd055 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
@@ -93,26 +93,26 @@ public class SnippetsBridge implements SuggestionsSource {
}
@Override
- public List<SnippetArticleListItem> getSuggestionsForCategory(int category) {
+ public List<SnippetArticle> getSuggestionsForCategory(int category) {
assert mNativeSnippetsBridge != 0;
return nativeGetSuggestionsForCategory(mNativeSnippetsBridge, category);
}
@Override
- public void fetchSuggestionImage(SnippetArticleListItem suggestion, Callback<Bitmap> callback) {
+ public void fetchSuggestionImage(SnippetArticle suggestion, Callback<Bitmap> callback) {
assert mNativeSnippetsBridge != 0;
nativeFetchSuggestionImage(mNativeSnippetsBridge, suggestion.mId, callback);
}
@Override
- public void dismissSuggestion(SnippetArticleListItem suggestion) {
+ public void dismissSuggestion(SnippetArticle suggestion) {
assert mNativeSnippetsBridge != 0;
nativeDismissSuggestion(mNativeSnippetsBridge, suggestion.mId);
}
@Override
public void getSuggestionVisited(
- SnippetArticleListItem suggestion, Callback<Boolean> callback) {
+ SnippetArticle suggestion, Callback<Boolean> callback) {
assert mNativeSnippetsBridge != 0;
nativeGetURLVisited(mNativeSnippetsBridge, callback, suggestion.mUrl);
}
@@ -135,16 +135,16 @@ public class SnippetsBridge implements SuggestionsSource {
}
@CalledByNative
- private static List<SnippetArticleListItem> createSuggestionList() {
+ private static List<SnippetArticle> createSuggestionList() {
return new ArrayList<>();
}
@CalledByNative
- private static void addSuggestion(List<SnippetArticleListItem> suggestions, String id,
+ private static void addSuggestion(List<SnippetArticle> suggestions, String id,
String title, String publisher, String previewText, String url, String ampUrl,
long timestamp, float score, int cardLayout) {
int position = suggestions.size();
- suggestions.add(new SnippetArticleListItem(id, title, publisher, previewText, url, ampUrl,
+ suggestions.add(new SnippetArticle(id, title, publisher, previewText, url, ampUrl,
timestamp, score, position, cardLayout));
}
@@ -175,7 +175,7 @@ public class SnippetsBridge implements SuggestionsSource {
private native int nativeGetCategoryStatus(long nativeNTPSnippetsBridge, int category);
private native SuggestionsCategoryInfo nativeGetCategoryInfo(
long nativeNTPSnippetsBridge, int category);
- private native List<SnippetArticleListItem> nativeGetSuggestionsForCategory(
+ private native List<SnippetArticle> nativeGetSuggestionsForCategory(
long nativeNTPSnippetsBridge, int category);
private native void nativeFetchSuggestionImage(
long nativeNTPSnippetsBridge, String suggestionId, Callback<Bitmap> callback);

Powered by Google App Engine
This is Rietveld 408576698