Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2906)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SectionHeader.java

Issue 2245013003: Remove "list item" from Android NTP class names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: x Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SectionHeader.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderListItem.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SectionHeader.java
similarity index 51%
rename from chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderListItem.java
rename to chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SectionHeader.java
index 84f0977de899ac65f5708438db3d64717671b0a4..be412212b4aa4c9c3c1ce72f2ca6fa4d56afa819 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderListItem.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SectionHeader.java
@@ -4,24 +4,19 @@
package org.chromium.chrome.browser.ntp.snippets;
-import android.view.LayoutInflater;
-import android.view.View;
-import android.view.ViewGroup;
-
-import org.chromium.chrome.R;
-import org.chromium.chrome.browser.ntp.cards.NewTabPageListItem;
+import org.chromium.chrome.browser.ntp.cards.NewTabPageItem;
/**
* Represents the data for a header of a group of snippets
*/
-public class SnippetHeaderListItem implements NewTabPageListItem {
+public class SectionHeader implements NewTabPageItem {
/** Whether the header should be shown. */
private final boolean mVisible;
/** The header text to be shown. */
private final String mHeaderText;
- public SnippetHeaderListItem(String headerText) {
+ public SectionHeader(String headerText) {
// TODO(mvanouwerkerk): Configure mVisible in the constructor when we have a global status
// section without a visible header.
mVisible = true;
@@ -29,20 +24,9 @@ public class SnippetHeaderListItem implements NewTabPageListItem {
this.mHeaderText = headerText;
}
- /**
- * Creates the View object for displaying the header for a group of snippets
- *
- * @param parent The parent view for the header
- * @return a View object for displaying a header for a group of snippets
- */
- public static View createView(ViewGroup parent) {
- return LayoutInflater.from(parent.getContext())
- .inflate(R.layout.new_tab_page_snippets_header, parent, false);
- }
-
@Override
public int getType() {
- return NewTabPageListItem.VIEW_TYPE_HEADER;
+ return NewTabPageItem.VIEW_TYPE_HEADER;
}
public boolean isVisible() {

Powered by Google App Engine
This is Rietveld 408576698