Componentize spellcheck [4]: spellcheck/browser and android java-side.

Componentize spellcheck [4]: spellcheck/browser and android java-side.

Move some files and unit tests from chrome/browser/spellchecker/ and
android-specific java code to the spellcheck component. This move
generally includes the android slice of spellchecker.

In particular in this patch:
 - move the relevant chrome/browser/spellchecker files and unit tests
 - move the android java files and create proper jni registrar
 - isolate spellcheck preference constants into separate files
 - properly initialize "java_object_initialization_failed_" in
   spellchecker_session_bridge_android.cc
 - update references in the code base
 - update and create build files

The main motivation behind the componentization of the spellcheck
feature is that we want to make it available in Android WebView.

Preceding spellcheck componentization patches:
[1] https://codereview.chromium.org/2166683003/
[2] https://codereview.chromium.org/2177343002/
[3] https://codereview.chromium.org/2198143002/

BUG=583616, 629609
TBR=jam@chromium.org

Committed: https://crrev.com/0eec9ec80a9f94acad54c0fe07e6e1bdd76643ec
Cr-Commit-Position: refs/heads/master@{#412549}

[timvolodine, 2016-08-13 03:23:08]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-13 03:23:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-13 03:30:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-13 03:30:28]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[timvolodine, 2016-08-15 12:31:58]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 12:32:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 12:38:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 12:38:59]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[timvolodine, 2016-08-15 12:51:34]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 12:51:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 12:57:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 12:57:10]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[timvolodine, 2016-08-15 13:21:25]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 13:21:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 13:25:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 13:25:07]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[timvolodine, 2016-08-15 14:47:05]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 14:47:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 14:51:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 14:51:31]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[timvolodine, 2016-08-15 15:41:13]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 15:41:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 15:48:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 15:48:48]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[timvolodine, 2016-08-15 17:08:59]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 17:09:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 17:17:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 17:17:42]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[timvolodine, 2016-08-15 17:54:18]

Description was changed from

==========
Componentize spellcheck [4]: spellcheck/browser and android java-side.

Move android related browser files to component. In particular in
this patch:
 - move the relevant chrome/browser/spellcheck files
 - move the android java files and create proper jni registrar
 - isolate spellcheck preference constants into separate files
 - update references in the code base
 - update build files

The main motivation behind the componentization of the spellcheck
feature is that we want to make it available in Android WebView.

Preceding spellcheck componentization patches:
[1] https://codereview.chromium.org/2166683003/
[2] https://codereview.chromium.org/2177343002/
[3] https://codereview.chromium.org/2198143002/

BUG=583616, 629609
==========

to

==========
Componentize spellcheck [4]: spellcheck/browser and android java-side.

Move android related browser files to component. In particular in
this patch:
 - move the relevant chrome/browser/spellcheck files
 - move the android java files and create proper jni registrar
 - isolate spellcheck preference constants into separate files
 - update references in the code base
 - update/create build files

The main motivation behind the componentization of the spellcheck
feature is that we want to make it available in Android WebView.

Preceding spellcheck componentization patches:
[1] https://codereview.chromium.org/2166683003/
[2] https://codereview.chromium.org/2177343002/
[3] https://codereview.chromium.org/2198143002/

BUG=583616, 629609
==========

[timvolodine, 2016-08-15 18:37:00]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 18:37:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[timvolodine, 2016-08-15 19:02:15]

Description was changed from

==========
Componentize spellcheck [4]: spellcheck/browser and android java-side.

Move android related browser files to component. In particular in
this patch:
 - move the relevant chrome/browser/spellcheck files
 - move the android java files and create proper jni registrar
 - isolate spellcheck preference constants into separate files
 - update references in the code base
 - update/create build files

The main motivation behind the componentization of the spellcheck
feature is that we want to make it available in Android WebView.

Preceding spellcheck componentization patches:
[1] https://codereview.chromium.org/2166683003/
[2] https://codereview.chromium.org/2177343002/
[3] https://codereview.chromium.org/2198143002/

BUG=583616, 629609
==========

to

==========
Componentize spellcheck [4]: spellcheck/browser and android java-side.

Move some files and unit tests from chrome/browser/spellchecker/ and
android-specific java code to the spellcheck component. This move
generally includes the android slice of spellchecker.

In particular in this patch:
 - move the relevant chrome/browser/spellchecker files and unit tests
 - move the android java files and create proper jni registrar
 - isolate spellcheck preference constants into separate files
 - properly initialize "java_object_initialization_failed_" in
   spellchecker_session_bridge_android.cc
 - update references in the code base
 - update and create build files

The main motivation behind the componentization of the spellcheck
feature is that we want to make it available in Android WebView.

Preceding spellcheck componentization patches:
[1] https://codereview.chromium.org/2166683003/
[2] https://codereview.chromium.org/2177343002/
[3] https://codereview.chromium.org/2198143002/

BUG=583616, 629609
==========

[timvolodine, 2016-08-15 19:39:29]

timvolodine@chromium.org changed reviewers:
+ groby@chromium.org, rouslan@chromium.org

[timvolodine, 2016-08-15 19:39:30]

groby@: could you please take a look?

[timvolodine, 2016-08-15 19:41:26]

timvolodine@chromium.org changed reviewers:
- rouslan@chromium.org

[commit-bot: I haz the power, 2016-08-15 20:34:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 20:34:25]

Dry run: This issue passed the CQ dry run.

[groby-ooo-7-16, 2016-08-15 20:47:20]

groby@chromium.org changed reviewers:
+ rouslan@chromium.org

[groby-ooo-7-16, 2016-08-15 20:47:22]

I'm very sporadically available until Friday due to conference attendance.

Rouslan, can you take a look?

[please use gerrit instead, 2016-08-15 21:49:05]

On 2016/08/15 20:47:22, groby wrote:
> Rouslan, can you take a look?

Looking.

[please use gerrit instead, 2016-08-15 22:58:23]

lgtm

[timvolodine, 2016-08-16 13:10:42]

On 2016/08/15 22:58:23, rouslan wrote:
> lgtm

rouslan@ thanks for the review!

[timvolodine, 2016-08-16 13:11:31]

timvolodine@chromium.org changed reviewers:
+ jam@chromium.org

[timvolodine, 2016-08-16 13:11:32]

jam@: for RS remaining chrome/ and component/ files

[timvolodine, 2016-08-16 13:12:55]

actually jam@ is OOO, so

thestig@: could you pls RS non-spellchecker chrome/ files?

[timvolodine, 2016-08-16 13:13:25]

timvolodine@chromium.org changed reviewers:
+ thestig@chromium.org

[timvolodine, 2016-08-16 13:13:26]

actually jam@ is OOO, so

thestig@: could you pls RS non-spellchecker chrome/ files?

[timvolodine, 2016-08-16 13:16:10]

timvolodine@chromium.org changed reviewers:
+ blundell@chromium.org

[timvolodine, 2016-08-16 13:16:11]

+blundell@: for components/BUILD.gn

[timvolodine, 2016-08-16 14:25:33]

timvolodine@chromium.org changed reviewers:
+ stevenjb@chromium.org

[timvolodine, 2016-08-16 14:25:34]

+stevenjb as owner for
chrome/browser/ui/webui/options/multilanguage_options_browsertest.cc

[blundell, 2016-08-16 14:38:02]

//components/spellcheck LGTM

[blundell, 2016-08-16 14:39:08]

On 2016/08/16 14:38:02, blundell wrote:
> //components/spellcheck LGTM

err, that is, //components/BUILD.gn lgtm.

[Lei Zhang, 2016-08-16 15:42:57]

lgtm

https://codereview.chromium.org/2244083002/diff/200001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/options/multilanguage_options_browsertest.cc
(right):

https://codereview.chromium.org/2244083002/diff/200001/chrome/browser/ui/webu...
chrome/browser/ui/webui/options/multilanguage_options_browsertest.cc:39:
browser()->profile()->GetPrefs()->SetString(
Maybe same the pointer from GetPrefs() on line 35 and reuse it here?

[stevenjb, 2016-08-16 15:46:55]

chrome/browser/ui/webui/options/ lgtm

[timvolodine, 2016-08-16 18:18:11]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 18:18:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[timvolodine, 2016-08-16 18:19:15]

thanks everybody for the quick review!

https://codereview.chromium.org/2244083002/diff/200001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/options/multilanguage_options_browsertest.cc
(right):

https://codereview.chromium.org/2244083002/diff/200001/chrome/browser/ui/webu...
chrome/browser/ui/webui/options/multilanguage_options_browsertest.cc:39:
browser()->profile()->GetPrefs()->SetString(
On 2016/08/16 15:42:57, Lei Zhang wrote:
> Maybe same the pointer from GetPrefs() on line 35 and reuse it here?

Done.

[commit-bot: I haz the power, 2016-08-16 18:25:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 18:25:42]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[timvolodine, 2016-08-17 14:31:51]

The CQ bit was checked by timvolodine@chromium.org

[timvolodine, 2016-08-17 14:31:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org, thestig@chromium.org, rouslan@chromium.org,
blundell@chromium.org
Link to the patchset: https://codereview.chromium.org/2244083002/#ps220001
(title: "rebase and address comment")

[commit-bot: I haz the power, 2016-08-17 14:32:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 14:46:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 14:46:22]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[timvolodine, 2016-08-17 14:59:15]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 14:59:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 15:59:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 15:59:52]

Dry run: This issue passed the CQ dry run.

[timvolodine, 2016-08-17 16:06:58]

The CQ bit was checked by timvolodine@chromium.org

[timvolodine, 2016-08-17 16:06:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org, thestig@chromium.org, rouslan@chromium.org,
blundell@chromium.org
Link to the patchset: https://codereview.chromium.org/2244083002/#ps240001
(title: "rebase")

[commit-bot: I haz the power, 2016-08-17 16:07:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 16:12:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 16:12:33]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[timvolodine, 2016-08-17 16:12:39]

Description was changed from

==========
Componentize spellcheck [4]: spellcheck/browser and android java-side.

Move some files and unit tests from chrome/browser/spellchecker/ and
android-specific java code to the spellcheck component. This move
generally includes the android slice of spellchecker.

In particular in this patch:
 - move the relevant chrome/browser/spellchecker files and unit tests
 - move the android java files and create proper jni registrar
 - isolate spellcheck preference constants into separate files
 - properly initialize "java_object_initialization_failed_" in
   spellchecker_session_bridge_android.cc
 - update references in the code base
 - update and create build files

The main motivation behind the componentization of the spellcheck
feature is that we want to make it available in Android WebView.

Preceding spellcheck componentization patches:
[1] https://codereview.chromium.org/2166683003/
[2] https://codereview.chromium.org/2177343002/
[3] https://codereview.chromium.org/2198143002/

BUG=583616, 629609
==========

to

==========
Componentize spellcheck [4]: spellcheck/browser and android java-side.

Move some files and unit tests from chrome/browser/spellchecker/ and
android-specific java code to the spellcheck component. This move
generally includes the android slice of spellchecker.

In particular in this patch:
 - move the relevant chrome/browser/spellchecker files and unit tests
 - move the android java files and create proper jni registrar
 - isolate spellcheck preference constants into separate files
 - properly initialize "java_object_initialization_failed_" in
   spellchecker_session_bridge_android.cc
 - update references in the code base
 - update and create build files

The main motivation behind the componentization of the spellcheck
feature is that we want to make it available in Android WebView.

Preceding spellcheck componentization patches:
[1] https://codereview.chromium.org/2166683003/
[2] https://codereview.chromium.org/2177343002/
[3] https://codereview.chromium.org/2198143002/

BUG=583616, 629609
TBR=jam@chromium.org
==========

[timvolodine, 2016-08-17 16:12:54]

The CQ bit was checked by timvolodine@chromium.org

[commit-bot: I haz the power, 2016-08-17 16:13:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 16:19:08]

Description was changed from

==========
Componentize spellcheck [4]: spellcheck/browser and android java-side.

Move some files and unit tests from chrome/browser/spellchecker/ and
android-specific java code to the spellcheck component. This move
generally includes the android slice of spellchecker.

In particular in this patch:
 - move the relevant chrome/browser/spellchecker files and unit tests
 - move the android java files and create proper jni registrar
 - isolate spellcheck preference constants into separate files
 - properly initialize "java_object_initialization_failed_" in
   spellchecker_session_bridge_android.cc
 - update references in the code base
 - update and create build files

The main motivation behind the componentization of the spellcheck
feature is that we want to make it available in Android WebView.

Preceding spellcheck componentization patches:
[1] https://codereview.chromium.org/2166683003/
[2] https://codereview.chromium.org/2177343002/
[3] https://codereview.chromium.org/2198143002/

BUG=583616, 629609
TBR=jam@chromium.org
==========

to

==========
Componentize spellcheck [4]: spellcheck/browser and android java-side.

Move some files and unit tests from chrome/browser/spellchecker/ and
android-specific java code to the spellcheck component. This move
generally includes the android slice of spellchecker.

In particular in this patch:
 - move the relevant chrome/browser/spellchecker files and unit tests
 - move the android java files and create proper jni registrar
 - isolate spellcheck preference constants into separate files
 - properly initialize "java_object_initialization_failed_" in
   spellchecker_session_bridge_android.cc
 - update references in the code base
 - update and create build files

The main motivation behind the componentization of the spellcheck
feature is that we want to make it available in Android WebView.

Preceding spellcheck componentization patches:
[1] https://codereview.chromium.org/2166683003/
[2] https://codereview.chromium.org/2177343002/
[3] https://codereview.chromium.org/2198143002/

BUG=583616, 629609
TBR=jam@chromium.org
==========

[commit-bot: I haz the power, 2016-08-17 16:19:10]

Committed patchset #13 (id:240001)

[commit-bot: I haz the power, 2016-08-17 16:21:24]

Description was changed from

==========
Componentize spellcheck [4]: spellcheck/browser and android java-side.

Move some files and unit tests from chrome/browser/spellchecker/ and
android-specific java code to the spellcheck component. This move
generally includes the android slice of spellchecker.

In particular in this patch:
 - move the relevant chrome/browser/spellchecker files and unit tests
 - move the android java files and create proper jni registrar
 - isolate spellcheck preference constants into separate files
 - properly initialize "java_object_initialization_failed_" in
   spellchecker_session_bridge_android.cc
 - update references in the code base
 - update and create build files

The main motivation behind the componentization of the spellcheck
feature is that we want to make it available in Android WebView.

Preceding spellcheck componentization patches:
[1] https://codereview.chromium.org/2166683003/
[2] https://codereview.chromium.org/2177343002/
[3] https://codereview.chromium.org/2198143002/

BUG=583616, 629609
TBR=jam@chromium.org
==========

to

==========
Componentize spellcheck [4]: spellcheck/browser and android java-side.

Move some files and unit tests from chrome/browser/spellchecker/ and
android-specific java code to the spellcheck component. This move
generally includes the android slice of spellchecker.

In particular in this patch:
 - move the relevant chrome/browser/spellchecker files and unit tests
 - move the android java files and create proper jni registrar
 - isolate spellcheck preference constants into separate files
 - properly initialize "java_object_initialization_failed_" in
   spellchecker_session_bridge_android.cc
 - update references in the code base
 - update and create build files

The main motivation behind the componentization of the spellcheck
feature is that we want to make it available in Android WebView.

Preceding spellcheck componentization patches:
[1] https://codereview.chromium.org/2166683003/
[2] https://codereview.chromium.org/2177343002/
[3] https://codereview.chromium.org/2198143002/

BUG=583616, 629609
TBR=jam@chromium.org

Committed: https://crrev.com/0eec9ec80a9f94acad54c0fe07e6e1bdd76643ec
Cr-Commit-Position: refs/heads/master@{#412549}
==========

[commit-bot: I haz the power, 2016-08-17 16:21:26]

Patchset 13 (id:??) landed as
https://crrev.com/0eec9ec80a9f94acad54c0fe07e6e1bdd76643ec
Cr-Commit-Position: refs/heads/master@{#412549}

[Avi (use Gerrit), 2016-08-17 19:17:06]

avi@chromium.org changed reviewers:
+ avi@chromium.org

[Avi (use Gerrit), 2016-08-17 19:17:09]

https://codereview.chromium.org/2244083002/diff/240001/chrome/chrome_browser....
File chrome/chrome_browser.gypi (left):

https://codereview.chromium.org/2244083002/diff/240001/chrome/chrome_browser....
chrome/chrome_browser.gypi:2982:
'browser/spellchecker/spelling_service_client.cc',
You added this file to components/spellcheck, and removed it from the build
file, but failed to remove the original from the original location. Please
follow up to remove this original file.

[timvolodine, 2016-08-18 12:15:35]

https://codereview.chromium.org/2244083002/diff/240001/chrome/chrome_browser....
File chrome/chrome_browser.gypi (left):

https://codereview.chromium.org/2244083002/diff/240001/chrome/chrome_browser....
chrome/chrome_browser.gypi:2982:
'browser/spellchecker/spelling_service_client.cc',
On 2016/08/17 19:17:09, Avi wrote:
> You added this file to components/spellcheck, and removed it from the build
> file, but failed to remove the original from the original location. Please
> follow up to remove this original file.

Thanks for catching this! removed in https://codereview.chromium.org/2260463002/