chrome/browser/renderer_context_menu/spelling_bubble_model.cc - Issue 2244083002: Componentize spellcheck [4]: spellcheck/browser and android java-side.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_context_menu/spelling_bubble_model.cc

Issue 2244083002: Componentize spellcheck [4]: spellcheck/browser and android java-side. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_context_menu/render_view_context_menu.cc ('k') | chrome/browser/renderer_context_menu/spelling_menu_observer.h » ('j') | chrome/chrome_browser.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_context_menu/spelling_bubble_model.cc

diff --git a/chrome/browser/renderer_context_menu/spelling_bubble_model.cc b/chrome/browser/renderer_context_menu/spelling_bubble_model.cc

index 2f16b42cb0bc971cfd3093650a0ad64a202f37e5..8a8c721c5fcbaf7fcea59014977d7d8cdff556b3 100644

--- a/chrome/browser/renderer_context_menu/spelling_bubble_model.cc

+++ b/chrome/browser/renderer_context_menu/spelling_bubble_model.cc

@@ -6,11 +6,11 @@

#include "base/logging.h"

#include "chrome/browser/profiles/profile.h"

-#include "chrome/common/pref_names.h"

#include "chrome/common/url_constants.h"

#include "chrome/grit/chromium_strings.h"

#include "chrome/grit/generated_resources.h"

#include "components/prefs/pref_service.h"

+#include "components/spellcheck/browser/pref_names.h"

#include "content/public/browser/web_contents.h"

#include "grit/components_strings.h"

#include "grit/theme_resources.h"

@@ -68,5 +68,5 @@ void SpellingBubbleModel::LinkClicked() {

void SpellingBubbleModel::SetPref(bool enabled) {

PrefService* pref = profile_->GetPrefs();

DCHECK(pref);

- pref->SetBoolean(prefs::kSpellCheckUseSpellingService, enabled);

+ pref->SetBoolean(spellcheck::prefs::kSpellCheckUseSpellingService, enabled);

}