Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3131)

Unified Diff: chrome/browser/spellchecker/spellcheck_host_metrics_unittest.cc

Issue 2244083002: Componentize spellcheck [4]: spellcheck/browser and android java-side. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/spellchecker/spellcheck_host_metrics_unittest.cc
diff --git a/chrome/browser/spellchecker/spellcheck_host_metrics_unittest.cc b/chrome/browser/spellchecker/spellcheck_host_metrics_unittest.cc
deleted file mode 100644
index 6ba1d818229eb9c3c7e2433467c03b60bd1464f8..0000000000000000000000000000000000000000
--- a/chrome/browser/spellchecker/spellcheck_host_metrics_unittest.cc
+++ /dev/null
@@ -1,116 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/browser/spellchecker/spellcheck_host_metrics.h"
-
-#include <stddef.h>
-
-#include <memory>
-
-#include "base/macros.h"
-#include "base/message_loop/message_loop.h"
-#include "base/metrics/histogram_samples.h"
-#include "base/metrics/statistics_recorder.h"
-#include "base/strings/utf_string_conversions.h"
-#include "base/test/histogram_tester.h"
-#include "build/build_config.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-#if defined(OS_WIN)
-// For version specific disabled tests below (http://crbug.com/230534).
-#include "base/win/windows_version.h"
-#endif
-
-class SpellcheckHostMetricsTest : public testing::Test {
- public:
- SpellcheckHostMetricsTest() {
- }
-
- static void SetUpTestCase() {
- base::StatisticsRecorder::Initialize();
- }
-
- void SetUp() override { metrics_.reset(new SpellCheckHostMetrics); }
-
- SpellCheckHostMetrics* metrics() { return metrics_.get(); }
- void RecordWordCountsForTesting() { metrics_->RecordWordCounts(); }
-
- private:
- base::MessageLoop loop_;
- std::unique_ptr<SpellCheckHostMetrics> metrics_;
-};
-
-TEST_F(SpellcheckHostMetricsTest, RecordEnabledStats) {
- const char kMetricName[] = "SpellCheck.Enabled";
- base::HistogramTester histogram_tester1;
-
- metrics()->RecordEnabledStats(false);
-
- histogram_tester1.ExpectBucketCount(kMetricName, 0, 1);
- histogram_tester1.ExpectBucketCount(kMetricName, 1, 0);
-
- base::HistogramTester histogram_tester2;
-
- metrics()->RecordEnabledStats(true);
-
- histogram_tester2.ExpectBucketCount(kMetricName, 0, 0);
- histogram_tester2.ExpectBucketCount(kMetricName, 1, 1);
-}
-
-TEST_F(SpellcheckHostMetricsTest, CustomWordStats) {
-#if defined(OS_WIN)
-// Failing consistently on Win7. See crbug.com/230534.
- if (base::win::GetVersion() >= base::win::VERSION_VISTA)
- return;
-#endif
- SpellCheckHostMetrics::RecordCustomWordCountStats(123);
-
- // Determine if test failures are due the statistics recorder not being
- // available or because the histogram just isn't there: crbug.com/230534.
- EXPECT_TRUE(base::StatisticsRecorder::IsActive());
-
- base::HistogramTester histogram_tester;
-
- SpellCheckHostMetrics::RecordCustomWordCountStats(23);
- histogram_tester.ExpectBucketCount("SpellCheck.CustomWords", 23, 1);
-}
-
-TEST_F(SpellcheckHostMetricsTest, RecordWordCountsDiscardsDuplicates) {
- // This test ensures that RecordWordCounts only records metrics if they
- // have changed from the last invocation.
- const char* const histogram_names[] = {
- "SpellCheck.CheckedWords", "SpellCheck.MisspelledWords",
- "SpellCheck.ReplacedWords", "SpellCheck.UniqueWords",
- "SpellCheck.ShownSuggestions"};
-
- // Ensure all histograms exist.
- metrics()->RecordCheckedWordStats(base::ASCIIToUTF16("test"), false);
- RecordWordCountsForTesting();
-
- // Create the tester, taking a snapshot of current histogram samples.
- base::HistogramTester histogram_tester;
-
- // Nothing changed, so this invocation should not affect any histograms.
- RecordWordCountsForTesting();
-
- // Get samples for all affected histograms.
- for (size_t i = 0; i < arraysize(histogram_names); ++i)
- histogram_tester.ExpectTotalCount(histogram_names[i], 0);
-}
-
-TEST_F(SpellcheckHostMetricsTest, RecordSpellingServiceStats) {
- const char kMetricName[] = "SpellCheck.SpellingService.Enabled";
- base::HistogramTester histogram_tester1;
-
- metrics()->RecordSpellingServiceStats(false);
-
- histogram_tester1.ExpectBucketCount(kMetricName, 0, 1);
- histogram_tester1.ExpectBucketCount(kMetricName, 1, 0);
-
- base::HistogramTester histogram_tester2;
-
- metrics()->RecordSpellingServiceStats(true);
- histogram_tester2.ExpectBucketCount(kMetricName, 0, 0);
- histogram_tester2.ExpectBucketCount(kMetricName, 1, 1);
-}

Powered by Google App Engine
This is Rietveld 408576698