chrome/browser/extensions/api/language_settings_private/language_settings_private_delegate.cc - Issue 2244083002: Componentize spellcheck [4]: spellcheck/browser and android java-side.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/language_settings_private/language_settings_private_delegate.cc

Issue 2244083002: Componentize spellcheck [4]: spellcheck/browser and android java-side. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | chrome/browser/extensions/api/preference/preference_api.cc » ('j') | chrome/chrome_browser.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/language_settings_private/language_settings_private_delegate.cc

diff --git a/chrome/browser/extensions/api/language_settings_private/language_settings_private_delegate.cc b/chrome/browser/extensions/api/language_settings_private/language_settings_private_delegate.cc

index 5092c74a426cad4feb706bb46589101ca95fba9c..4868b0af202a5716a10ffdadcd43e0ca649c047b 100644

--- a/chrome/browser/extensions/api/language_settings_private/language_settings_private_delegate.cc

+++ b/chrome/browser/extensions/api/language_settings_private/language_settings_private_delegate.cc

@@ -19,8 +19,8 @@

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/spellchecker/spellcheck_factory.h"

#include "chrome/browser/spellchecker/spellcheck_service.h"

-#include "chrome/common/pref_names.h"

#include "components/prefs/pref_service.h"

+#include "components/spellcheck/browser/pref_names.h"

#include "content/public/browser/browser_context.h"

#include "content/public/browser/notification_source.h"

@@ -210,9 +210,11 @@ void LanguageSettingsPrivateDelegate::

// Update and observe the hunspell dictionaries.

RefreshDictionaries(listening_spellcheck_, should_listen);

// Observe the dictionaries preference.

- pref_change_registrar_.Add(prefs::kSpellCheckDictionaries, base::Bind(

- &LanguageSettingsPrivateDelegate::OnSpellcheckDictionariesChanged,

- base::Unretained(this)));

+ pref_change_registrar_.Add(

+ spellcheck::prefs::kSpellCheckDictionaries,

+ base::Bind(

+ &LanguageSettingsPrivateDelegate::OnSpellcheckDictionariesChanged,

+ base::Unretained(this)));

// Observe the dictionary of custom words.

if (custom_dictionary_)

custom_dictionary_->AddObserver(this);

@@ -220,7 +222,7 @@ void LanguageSettingsPrivateDelegate::

// Stop observing any dictionaries that still exist.

RemoveDictionaryObservers();

hunspell_dictionaries_.clear();

- pref_change_registrar_.Remove(prefs::kSpellCheckDictionaries);

+ pref_change_registrar_.Remove(spellcheck::prefs::kSpellCheckDictionaries);

if (custom_dictionary_)

custom_dictionary_->RemoveObserver(this);

}