Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2242853002: Deprecate DirectoryBasedDartSdk and transition existing uses to the new API (Closed)

Created:
4 years, 4 months ago by Brian Wilkerson
Modified:
4 years, 4 months ago
Reviewers:
skybrian, scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Deprecate DirectoryBasedDartSdk and transition existing uses to the new API R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/c41427383b8dbe5fc49e0980bfb44c74f18d397b

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -134 lines) Patch
M pkg/analysis_server/lib/src/server/driver.dart View 4 chunks +12 lines, -10 lines 1 comment Download
M pkg/analysis_server/lib/src/socket_server.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/source/caching_pub_package_map_provider.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/status/get_handler.dart View 3 chunks +3 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/socket_server_test.dart View 2 chunks +6 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/source/caching_put_package_map_provider_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/analyzer/benchmark/errors_in_all_libraries.dart View 3 chunks +12 lines, -11 lines 0 comments Download
M pkg/analyzer/example/resolver_driver.dart View 2 chunks +7 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/source/pub_package_map_provider.dart View 4 chunks +4 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/dart/sdk/sdk.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/sdk_io.dart View 4 chunks +6 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summary_file_builder.dart View 6 chunks +14 lines, -13 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 11 chunks +30 lines, -18 lines 0 comments Download
M pkg/analyzer/test/generated/analysis_context_factory.dart View 3 chunks +39 lines, -24 lines 0 comments Download
M pkg/analyzer/test/source/package_map_provider_test.dart View 3 chunks +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/context/cache_test.dart View 2 chunks +6 lines, -3 lines 0 comments Download
M pkg/analyzer/test/stress/for_git_repository.dart View 5 chunks +8 lines, -5 lines 0 comments Download
M pkg/analyzer/tool/summary/build_sdk_summaries.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M pkg/analyzer/tool/task_dependency_graph/generate.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/analyzer_cli/lib/src/build_mode.dart View 2 chunks +7 lines, -7 lines 0 comments Download
M pkg/analyzer_cli/lib/src/driver.dart View 2 chunks +5 lines, -6 lines 0 comments Download
M pkg/analyzer_cli/lib/src/incremental_analyzer.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer_cli/test/embedder_test.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M pkg/analyzer_cli/test/sdk_ext_test.dart View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Brian Wilkerson
4 years, 4 months ago (2016-08-12 15:26:51 UTC) #2
scheglov
LGTM
4 years, 4 months ago (2016-08-12 16:08:39 UTC) #3
Brian Wilkerson
Committed patchset #1 (id:1) manually as c41427383b8dbe5fc49e0980bfb44c74f18d397b (presubmit successful).
4 years, 4 months ago (2016-08-12 16:18:17 UTC) #5
skybrian
4 years, 4 months ago (2016-08-24 01:55:10 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/2242853002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/server/driver.dart (right):

https://codereview.chromium.org/2242853002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/server/driver.dart:421: FolderBasedDartSdk sdk = new
FolderBasedDartSdk(resourceProvider,
This seems to have broken the --sdk flag. Its value isn't being passed to the
FolderBasedDartSdk constructor.

Powered by Google App Engine
This is Rietveld 408576698