pkg/analyzer_cli/test/embedder_test.dart - Issue 2242853002: Deprecate DirectoryBasedDartSdk and transition existing uses to the new API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer_cli/test/embedder_test.dart

Issue 2242853002: Deprecate DirectoryBasedDartSdk and transition existing uses to the new API (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/analysis_server/lib/src/server/driver.dart ('K') | « pkg/analyzer_cli/lib/src/incremental_analyzer.dart ('k') | pkg/analyzer_cli/test/sdk_ext_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analyzer_cli/test/embedder_test.dart

diff --git a/pkg/analyzer_cli/test/embedder_test.dart b/pkg/analyzer_cli/test/embedder_test.dart

index 5a57c2d9c1141c4292c35f78fe3945d552b701f4..93bbaf5c2703f1d2069eb7a556a163911b3a0566 100644

--- a/pkg/analyzer_cli/test/embedder_test.dart

+++ b/pkg/analyzer_cli/test/embedder_test.dart

@@ -4,7 +4,8 @@

import 'dart:io';

-import 'package:analyzer/src/generated/sdk_io.dart';

+import 'package:analyzer/src/dart/sdk/sdk.dart';

+import 'package:analyzer/src/generated/sdk.dart';

import 'package:analyzer_cli/src/driver.dart' show Driver, errorSink, outSink;

import 'package:path/path.dart' as path;

import 'package:unittest/unittest.dart';

@@ -52,8 +53,9 @@ main() {

path.join(testDir, 'embedder_yaml_user.dart')

]);

- DirectoryBasedDartSdk sdk = driver.sdk;

- expect(sdk.useSummary, false);

+ DartSdk sdk = driver.sdk;

+ expect(sdk, new isInstanceOf<FolderBasedDartSdk>());

+ expect((sdk as FolderBasedDartSdk).useSummary, isFalse);

}));

});

}