pkg/analysis_server/lib/src/status/get_handler.dart - Issue 2242853002: Deprecate DirectoryBasedDartSdk and transition existing uses to the new API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/status/get_handler.dart

Issue 2242853002: Deprecate DirectoryBasedDartSdk and transition existing uses to the new API (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/analysis_server/lib/src/server/driver.dart ('K') | « pkg/analysis_server/lib/src/source/caching_pub_package_map_provider.dart ('k') | pkg/analysis_server/test/socket_server_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/status/get_handler.dart

diff --git a/pkg/analysis_server/lib/src/status/get_handler.dart b/pkg/analysis_server/lib/src/status/get_handler.dart

index 11cccffc1e21e8adefaa8753068874e7b23997a2..d3a8cdffa1ba6c1f35e7fd57ae44ace8a0c4a94f 100644

--- a/pkg/analysis_server/lib/src/status/get_handler.dart

+++ b/pkg/analysis_server/lib/src/status/get_handler.dart

@@ -39,7 +39,6 @@ import 'package:analyzer/src/generated/error.dart';

import 'package:analyzer/src/generated/java_engine.dart';

import 'package:analyzer/src/generated/resolver.dart';

import 'package:analyzer/src/generated/sdk.dart';

-import 'package:analyzer/src/generated/sdk_io.dart';

import 'package:analyzer/src/generated/source.dart';

import 'package:analyzer/src/generated/utilities_collection.dart';

import 'package:analyzer/src/generated/utilities_general.dart';

@@ -1453,7 +1452,7 @@ class GetHandler {

DartSdk sdk = context?.sourceFactory?.dartSdk;

writeOptions(buffer, sdk?.context?.analysisOptions,

writeAdditionalOptions: (StringBuffer buffer) {

- if (sdk is DirectoryBasedDartSdk) {

+ if (sdk is FolderBasedDartSdk) {

_writeOption(buffer, 'Use summaries', sdk.useSummary);

}

});

@@ -1490,9 +1489,9 @@ class GetHandler {

DartSdk sdk = resolver.dartSdk;

buffer.write(' (sdk = ');

buffer.write(sdk.runtimeType);

- if (sdk is DirectoryBasedDartSdk) {

+ if (sdk is FolderBasedDartSdk) {

buffer.write(' (path = ');

- buffer.write(sdk.directory.getAbsolutePath());

+ buffer.write(sdk.directory.path);

buffer.write(')');

} else if (sdk is EmbedderSdk) {

buffer.write(' (map = ');