pkg/analysis_server/lib/src/source/caching_pub_package_map_provider.dart - Issue 2242853002: Deprecate DirectoryBasedDartSdk and transition existing uses to the new API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/source/caching_pub_package_map_provider.dart

Issue 2242853002: Deprecate DirectoryBasedDartSdk and transition existing uses to the new API (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/analysis_server/lib/src/server/driver.dart ('K') | « pkg/analysis_server/lib/src/socket_server.dart ('k') | pkg/analysis_server/lib/src/status/get_handler.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/source/caching_pub_package_map_provider.dart

diff --git a/pkg/analysis_server/lib/src/source/caching_pub_package_map_provider.dart b/pkg/analysis_server/lib/src/source/caching_pub_package_map_provider.dart

index 1997bffeb15a53eadf45ddb1b7fe464aa978ebb8..48abf8ef1f95f3a487af51c32c74de7f09b5fd01 100644

--- a/pkg/analysis_server/lib/src/source/caching_pub_package_map_provider.dart

+++ b/pkg/analysis_server/lib/src/source/caching_pub_package_map_provider.dart

@@ -11,8 +11,8 @@ import 'dart:io' as io;

import 'package:analyzer/file_system/file_system.dart';

import 'package:analyzer/source/package_map_provider.dart';

import 'package:analyzer/source/pub_package_map_provider.dart';

+import 'package:analyzer/src/dart/sdk/sdk.dart';

import 'package:analyzer/src/generated/engine.dart';

-import 'package:analyzer/src/generated/sdk_io.dart';

import 'package:analyzer/src/generated/source.dart';

/**

@@ -80,7 +80,7 @@ class CachingPubPackageMapProvider extends PubPackageMapProvider {

* [RunPubList] and [WriteFile] implementations may be injected for testing

CachingPubPackageMapProvider(

- ResourceProvider resourceProvider, DirectoryBasedDartSdk sdk,

+ ResourceProvider resourceProvider, FolderBasedDartSdk sdk,

[RunPubList runPubList, this._writeFile])

: super(resourceProvider, sdk, runPubList) {

if (_writeFile == null) {