Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: pkg/analyzer_cli/lib/src/build_mode.dart

Issue 2242853002: Deprecate DirectoryBasedDartSdk and transition existing uses to the new API (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer_cli/lib/src/build_mode.dart
diff --git a/pkg/analyzer_cli/lib/src/build_mode.dart b/pkg/analyzer_cli/lib/src/build_mode.dart
index 5b9ec2c5a0d513f3ba60af15e28c53490dd95ad5..b69669db2f17e405125c73366cf69cc8d4f83462 100644
--- a/pkg/analyzer_cli/lib/src/build_mode.dart
+++ b/pkg/analyzer_cli/lib/src/build_mode.dart
@@ -10,11 +10,11 @@ import 'dart:io' as io;
import 'package:analyzer/dart/ast/ast.dart' show CompilationUnit;
import 'package:analyzer/dart/element/element.dart';
import 'package:analyzer/file_system/file_system.dart';
+import 'package:analyzer/src/dart/sdk/sdk.dart';
import 'package:analyzer/src/generated/engine.dart';
import 'package:analyzer/src/generated/error.dart';
import 'package:analyzer/src/generated/java_io.dart';
import 'package:analyzer/src/generated/sdk.dart';
-import 'package:analyzer/src/generated/sdk_io.dart';
import 'package:analyzer/src/generated/source.dart';
import 'package:analyzer/src/generated/source_io.dart';
import 'package:analyzer/src/summary/format.dart';
@@ -273,13 +273,13 @@ class BuildMode {
sdk = summarySdk;
sdkBundle = summarySdk.bundle;
} else {
- DirectoryBasedDartSdk directorySdk =
- new DirectoryBasedDartSdk(new JavaFile(options.dartSdkPath));
- directorySdk.analysisOptions =
+ FolderBasedDartSdk dartSdk = new FolderBasedDartSdk(resourceProvider,
+ resourceProvider.getFolder(options.dartSdkPath), options.strongMode);
+ dartSdk.analysisOptions =
Driver.createAnalysisOptionsForCommandLineOptions(options);
- directorySdk.useSummary = !options.buildSummaryOnlyAst;
- sdk = directorySdk;
- sdkBundle = directorySdk.getSummarySdkBundle(options.strongMode);
+ dartSdk.useSummary = !options.buildSummaryOnlyAst;
+ sdk = dartSdk;
+ sdkBundle = dartSdk.getSummarySdkBundle(options.strongMode);
}
// In AST mode include SDK bundle to avoid parsing SDK sources.

Powered by Google App Engine
This is Rietveld 408576698