Remove url_replacement logic from Omnibox/ToolbarModel

Remove url_replacement logic from Omnibox/ToolbarModel

Follow-up to https://codereview.chromium.org/2256613002/

BUG=627747, 447810
Committed: https://crrev.com/f5a290136489fed2a16ead7552e4d5f8f9ed1f43
Cr-Commit-Position: refs/heads/master@{#416233}

[Marc Treib, 2016-08-19 11:14:15]

Description was changed from

==========
Remove url_replacement logic from Omnibox/ToolbarModel

BUG=627747
==========

to

==========
Remove url_replacement logic from Omnibox/ToolbarModel

Follow-up to https://codereview.chromium.org/2256613002/

BUG=627747
==========

[Marc Treib, 2016-08-19 11:15:19]

treib@chromium.org changed reviewers:
+ pkasting@chromium.org

[Marc Treib, 2016-08-19 11:15:20]

PTAL!

[Peter Kasting, 2016-08-19 22:40:07]

LGTM

https://codereview.chromium.org/2242213008/diff/1/components/omnibox/browser/...
File components/omnibox/browser/omnibox_edit_model.cc (right):

https://codereview.chromium.org/2242213008/diff/1/components/omnibox/browser/...
components/omnibox/browser/omnibox_edit_model.cc:282: (gray_text.empty() ||
new_permanent_text != user_text_ + gray_text);
BTW, would you be averse to sticking all the "gray text" stuff on your list to
clean up as well?  That is related to the old "instant" functionality and has
been dead even longer.

https://codereview.chromium.org/2242213008/diff/1/components/toolbar/toolbar_...
File components/toolbar/toolbar_model.cc (right):

https://codereview.chromium.org/2242213008/diff/1/components/toolbar/toolbar_...
components/toolbar/toolbar_model.cc:8: : input_in_progress_(false) {
Nit: Can be on previous line

I might just inline this into the header.

https://codereview.chromium.org/2242213008/diff/1/components/toolbar/toolbar_...
components/toolbar/toolbar_model.cc:11: ToolbarModel::~ToolbarModel() {
Nit: I'd remove this and just use =default in the .h

[Marc Treib, 2016-08-22 08:45:55]

https://codereview.chromium.org/2242213008/diff/1/components/omnibox/browser/...
File components/omnibox/browser/omnibox_edit_model.cc (right):

https://codereview.chromium.org/2242213008/diff/1/components/omnibox/browser/...
components/omnibox/browser/omnibox_edit_model.cc:282: (gray_text.empty() ||
new_permanent_text != user_text_ + gray_text);
On 2016/08/19 22:40:06, Peter Kasting wrote:
> BTW, would you be averse to sticking all the "gray text" stuff on your list to
> clean up as well?  That is related to the old "instant" functionality and has
> been dead even longer.

Not averse as such, but as much as I like removing dead code, it's always hard
to find the time... consider it added to the list, but no promises that it's
gonna happen any time soon.

https://codereview.chromium.org/2242213008/diff/1/components/toolbar/toolbar_...
File components/toolbar/toolbar_model.cc (right):

https://codereview.chromium.org/2242213008/diff/1/components/toolbar/toolbar_...
components/toolbar/toolbar_model.cc:8: : input_in_progress_(false) {
On 2016/08/19 22:40:06, Peter Kasting wrote:
> Nit: Can be on previous line
> 
> I might just inline this into the header.

Done.

https://codereview.chromium.org/2242213008/diff/1/components/toolbar/toolbar_...
components/toolbar/toolbar_model.cc:11: ToolbarModel::~ToolbarModel() {
On 2016/08/19 22:40:06, Peter Kasting wrote:
> Nit: I'd remove this and just use =default in the .h

Done.

[Marc Treib, 2016-08-30 14:06:06]

Description was changed from

==========
Remove url_replacement logic from Omnibox/ToolbarModel

Follow-up to https://codereview.chromium.org/2256613002/

BUG=627747
==========

to

==========
Remove url_replacement logic from Omnibox/ToolbarModel

Follow-up to https://codereview.chromium.org/2256613002/

BUG=627747,447810
==========

[Marc Treib, 2016-09-02 09:35:51]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 09:36:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 10:37:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 10:37:18]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2016-09-02 11:03:46]

The CQ bit was checked by treib@chromium.org

[Marc Treib, 2016-09-02 11:03:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2242213008/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-09-02 11:04:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 11:08:32]

Description was changed from

==========
Remove url_replacement logic from Omnibox/ToolbarModel

Follow-up to https://codereview.chromium.org/2256613002/

BUG=627747,447810
==========

to

==========
Remove url_replacement logic from Omnibox/ToolbarModel

Follow-up to https://codereview.chromium.org/2256613002/

BUG=627747,447810
==========

[commit-bot: I haz the power, 2016-09-02 11:08:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-02 11:10:17]

Description was changed from

==========
Remove url_replacement logic from Omnibox/ToolbarModel

Follow-up to https://codereview.chromium.org/2256613002/

BUG=627747,447810
==========

to

==========
Remove url_replacement logic from Omnibox/ToolbarModel

Follow-up to https://codereview.chromium.org/2256613002/

BUG=627747,447810

Committed: https://crrev.com/f5a290136489fed2a16ead7552e4d5f8f9ed1f43
Cr-Commit-Position: refs/heads/master@{#416233}
==========

[commit-bot: I haz the power, 2016-09-02 11:10:18]

Patchset 3 (id:??) landed as
https://crrev.com/f5a290136489fed2a16ead7552e4d5f8f9ed1f43
Cr-Commit-Position: refs/heads/master@{#416233}